fix(images): disable false positive error logs about not ready datasource (#1050)

Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>

Author: eofff

images/virtualization-artifact/pkg/controller/cvi/internal/source/object_ref.go

@@ -368,7 +368,7 @@ func (ds ObjectRefDataSource) Validate(ctx context.Context, cvi *virtv2.ClusterV
 		}
 
 		if vdSnapshot == nil {
-			return fmt.Errorf("VDSnapshot object ref %s is nil", vdSnapshotKey)
+			return NewVirtualDiskSnapshotNotReadyError(cvi.Spec.DataSource.ObjectRef.Name)
 		}
 
 		return ds.vdSnapshotSyncer.Validate(ctx, cvi)

images/virtualization-artifact/pkg/controller/vi/internal/source/object_ref.go

@@ -501,7 +501,7 @@ func (ds ObjectRefDataSource) Validate(ctx context.Context, vi *virtv2.VirtualIm
 		}
 
 		if viRef == nil {
-			return fmt.Errorf("VI object ref source %s is nil", vi.Spec.DataSource.ObjectRef.Name)
+			return NewImageNotReadyError(vi.Spec.DataSource.ObjectRef.Name)
 		}
 
 		if viRef.Spec.Storage == virtv2.StorageKubernetes || viRef.Spec.Storage == virtv2.StoragePersistentVolumeClaim {

tests/e2e/default_config.yaml

@@ -42,9 +42,6 @@ logFilter:
   - "Server rejected event (will not retry!)" # Msg.
   - "validation failed for data source objectref" # Err.
   - "clean up failed for data source registry" # Err.
-  - "VDSnapshot object ref" # Err.
-  - "VirtualDiskSnapshot " # Err.
-  - "VI object ref source " # Err.
   - "the server rejected our request due to an error in our request" # Err.
   - "failed to sync powerstate" # Msg.
   - "failed to sync virtual disk data source objectref" # "err": "failed to sync virtual disk data source objectref: admission webhook \"datavolume-validate.cdi.kubevirt.io\" denied the request:  Destination PVC winwin/vd-win2022-8a136ef9-32d9-4ae3-a27f-e42e15c15f47 already exists"