feat(vm): set error policy report as default (#983)

Change VM behavior to I/O problems for disks.

Previously, the presence of I/O problems stopped the VM and paused it.

Now, instead of stopping the VM, I/O errors will be reported to the guest OS, allowing the guest system to deal with the problem (e.g., through retry mechanisms,
failover).

Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>

Author: yaroslavborbat

images/virtualization-artifact/pkg/apiserver/registry/vm/rest/add_volume.go

@@ -26,6 +26,7 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apiserver/pkg/registry/rest"
+	"k8s.io/utils/ptr"
 	virtv1 "kubevirt.io/api/core/v1"
 
 	"github.com/deckhouse/virtualization-controller/pkg/tls/certmanager"
@@ -122,9 +123,10 @@ func (r AddVolumeREST) genMutateRequestHook(opts *subresources.VirtualMachineAdd
 	hotplugRequest := AddVolumeOptions{
 		Name: opts.Name,
 		Disk: &virtv1.Disk{
-			Name:       opts.Name,
-			DiskDevice: dd,
-			Serial:     serial,
+			Name:        opts.Name,
+			DiskDevice:  dd,
+			Serial:      serial,
+			ErrorPolicy: ptr.To(virtv1.DiskErrorPolicyReport),
 		},
 	}
 	switch opts.VolumeKind {

images/virtualization-artifact/pkg/controller/kvbuilder/kvvm.go

@@ -25,6 +25,7 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/apimachinery/pkg/util/intstr"
+	"k8s.io/utils/ptr"
 	virtv1 "kubevirt.io/api/core/v1"
 
 	"github.com/deckhouse/virtualization-controller/pkg/common"
@@ -307,9 +308,10 @@ func (b *KVVM) SetDisk(name string, opts SetDiskOptions) error {
 	}
 
 	disk := virtv1.Disk{
-		Name:       name,
-		DiskDevice: dd,
-		Serial:     opts.Serial,
+		Name:        name,
+		DiskDevice:  dd,
+		Serial:      opts.Serial,
+		ErrorPolicy: ptr.To(virtv1.DiskErrorPolicyReport),
 	}
 
 	if opts.BootOrder > 0 {