Skip to content

Commit f336835

Browse files
author
Roman Sysoev
committed
fix(vi,vd): fix review comments
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
1 parent a0840f3 commit f336835

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

api/core/v1alpha2/vicondition/condition.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,8 @@ const (
7979
ProvisioningNotStarted ReadyReason = "ProvisioningNotStarted"
8080
// ProvisioningFailed indicates that the provisioning process has failed.
8181
ProvisioningFailed ReadyReason = "ProvisioningFailed"
82+
// StorageClassNotReady indicates that the provisioning process pending because `StorageClass` not ready.
83+
StorageClassNotReady ReadyReason = "StorageClassNotReady"
8284
// Ready indicates that the import process is complete and the `VirtualImage` is ready for use.
8385
Ready ReadyReason = "Ready"
8486
// QuotaExceeded indicates that the VirtualImage is reached project quotas and can not be provisioned.
@@ -91,8 +93,6 @@ const (
9193

9294
// StorageClassReady indicates that the chosen StorageClass exists.
9395
StorageClassReady StorageClassReadyReason = "StorageClassReady"
94-
// StorageClassNotReady indicates that the provisioning process pending because `StorageClass` not ready.
95-
StorageClassNotReady ReadyReason = "StorageClassNotReady"
9696
// StorageClassNotFound indicates that the chosen StorageClass not found.
9797
StorageClassNotFound StorageClassReadyReason = "StorageClassNotFound"
9898
// DVCRTypeUsed indicates that the DVCR provisioning chosen.

images/virtualization-artifact/pkg/controller/service/vi_storage_class_service.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ func NewVirtualImageStorageClassService(settings config.VirtualImageStorageClass
3939
}
4040
}
4141

42-
// GetStorageClass determines the storage class for VI from global settings and resource spec.
42+
// GetValidatedStorageClass determines the storage class for VI from global settings and resource spec.
4343
//
4444
// Global settings contain a default storage class and an array of allowed storageClasses from the ModuleConfig.
4545
// Storage class is allowed if contained in the "allowed" array.

0 commit comments

Comments
 (0)