Skip to content

fix(vmipl): fix problem with deleting the finalizer#1006

Merged
Isteb4k merged 1 commit into
mainfrom
chore/vmipl/refactor-controller
May 5, 2025
Merged

fix(vmipl): fix problem with deleting the finalizer#1006
Isteb4k merged 1 commit into
mainfrom
chore/vmipl/refactor-controller

Conversation

@LopatinDmitr
Copy link
Copy Markdown
Contributor

@LopatinDmitr LopatinDmitr commented May 5, 2025

Description

Fix problem with deleting the finalizer from VirtualMachineIPLease.

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vmipl
type: fix
summary: Fixed an issue with the incorrect removal of the finalizer from the VirtualMachineIPLease resource.

Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr LopatinDmitr self-assigned this May 5, 2025
@LopatinDmitr LopatinDmitr added this to the v0.18.0 milestone May 5, 2025
@LopatinDmitr LopatinDmitr added the e2e/run Run e2e test on cluster of PR author label May 5, 2025
@deckhouse-BOaTswain
Copy link
Copy Markdown
Contributor

deckhouse-BOaTswain commented May 5, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@LopatinDmitr LopatinDmitr marked this pull request as ready for review May 5, 2025 09:08
@LopatinDmitr LopatinDmitr requested a review from Isteb4k as a code owner May 5, 2025 09:08
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label May 5, 2025
@LopatinDmitr LopatinDmitr changed the title chore(vmipl): refactor controller fix(vmipl): fix problem with deleting the finalizer May 5, 2025
@Isteb4k Isteb4k merged commit 7e851ab into main May 5, 2025
65 of 72 checks passed
@Isteb4k Isteb4k deleted the chore/vmipl/refactor-controller branch May 5, 2025 11:03
yachmenevas pushed a commit that referenced this pull request Oct 15, 2025
Fix problem with deleting the finalizer from VirtualMachineIPLease.

Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants