Skip to content

fix(vmip): fix creating many vmipleases#1012

Merged
LopatinDmitr merged 17 commits into
mainfrom
fix/vmip/fix-double-vmiplease
May 16, 2025
Merged

fix(vmip): fix creating many vmipleases#1012
LopatinDmitr merged 17 commits into
mainfrom
fix/vmip/fix-double-vmiplease

Conversation

@LopatinDmitr
Copy link
Copy Markdown
Contributor

@LopatinDmitr LopatinDmitr commented May 6, 2025 •
edited
Loading

Description

Fix creating many vmipleases from one vmip.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vmip
type: fix
summary: Fix creating many vmipleases from one vmip.

@LopatinDmitr LopatinDmitr added this to the v0.18.0 milestone May 6, 2025
@LopatinDmitr LopatinDmitr changed the title Fix/vmip/fix double vmiplease fix(vmip): fix creating many vmipleases May 6, 2025
@LopatinDmitr LopatinDmitr force-pushed the fix/vmip/fix-double-vmiplease branch 5 times, most recently from 1ab9e04 to b7a578e Compare May 11, 2025 18:41
@LopatinDmitr
update protection_handler.go
358c40e 
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr
minor fix
85fc2f1 
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr
refactor lifecycle_handler.go
6ec736c 
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr
fix iplease_handler.go
323b01f 
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr
fix state.go
7b500d3 
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr
fix to worked
798440e 
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr LopatinDmitr force-pushed the fix/vmip/fix-double-vmiplease branch from b7a578e to 75bace6 Compare May 12, 2025 06:31
@LopatinDmitr
right way
2fadb8b 
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@universal-itengineer universal-itengineer modified the milestones: v0.18.0, v0.19.0 May 12, 2025
@LopatinDmitr
right way part 2
afcf7d3 
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr
right way part 3
e8ec9f5 
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr
right way part 4
d98af9e 
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr LopatinDmitr force-pushed the fix/vmip/fix-double-vmiplease branch from 75bace6 to d98af9e Compare May 12, 2025 14:24
@LopatinDmitr
polishing
44e0435 
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr
polishing 2
2d86037 
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr
polishing 3
9cd5cf1 
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr
polishing 3
4eb54fe 
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr LopatinDmitr added the e2e/run Run e2e test on cluster of PR author label May 12, 2025
@deckhouse-BOaTswain
Copy link
Copy Markdown
Contributor

deckhouse-BOaTswain commented May 12, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: success.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label May 12, 2025
@LopatinDmitr LopatinDmitr marked this pull request as ready for review May 13, 2025 03:05
yaroslavborbat
yaroslavborbat requested changes May 14, 2025
View reviewed changes
Comment thread images/virtualization-artifact/pkg/controller/vmip/internal/iplease_handler.go Outdated
Comment thread images/virtualization-artifact/pkg/controller/vmip/internal/iplease_handler.go Outdated
Comment thread images/virtualization-artifact/pkg/controller/vmip/internal/lifecycle_handler.go Outdated
Comment thread images/virtualization-artifact/pkg/controller/vmip/internal/lifecycle_handler.go
LopatinDmitr and others added 3 commits May 14, 2025 10:54
@LopatinDmitr @yaroslavborbat
Update images/virtualization-artifact/pkg/controller/vmip/internal/ip…
8184123 
…lease_handler.go

Co-authored-by: Yaroslav Borbat <86148689+yaroslavborbat@users.noreply.github.com>
Signed-off-by: Dmitry Lopatin <93423466+LopatinDmitr@users.noreply.github.com>
@LopatinDmitr
fix after review
72496d7 
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr
fix after review
70d9c0a 
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr LopatinDmitr added the e2e/run Run e2e test on cluster of PR author label May 14, 2025
@deckhouse-BOaTswain
Copy link
Copy Markdown
Contributor

deckhouse-BOaTswain commented May 14, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: success.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label May 14, 2025
@LopatinDmitr LopatinDmitr merged commit d840e0c into main May 16, 2025
66 checks passed
@LopatinDmitr LopatinDmitr deleted the fix/vmip/fix-double-vmiplease branch May 16, 2025 07:02
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request May 16, 2025
Merged
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request May 29, 2025
Merged
yachmenevas pushed a commit that referenced this pull request Oct 15, 2025
@LopatinDmitr @yaroslavborbat
fix(vmip): fix creating many vmipleases (#1012)
20bf1b7 
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
Signed-off-by: Dmitry Lopatin <93423466+LopatinDmitr@users.noreply.github.com>
Co-authored-by: Yaroslav Borbat <86148689+yaroslavborbat@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaroslavborbat yaroslavborbat yaroslavborbat approved these changes

@Isteb4k Isteb4k Awaiting requested review from Isteb4k Isteb4k is a code owner

Assignees

@LopatinDmitr LopatinDmitr

Labels

None yet

Projects

None yet

Milestone

v0.19.0

Development

Successfully merging this pull request may close these issues.

4 participants

@LopatinDmitr @deckhouse-BOaTswain @yaroslavborbat @universal-itengineer