feat(vd): remove finalizer from unmounted vd#1014
Merged
Merged
Conversation
Contributor
|
Workflow has started. The target step completed with status: failure. |
hardcoretime
force-pushed
the
feat/vd/remove-finalizer-from-unmounted-vd
branch
from
fc56eaf to
fecc90c
Compare
LopatinDmitr
reviewed
May 7, 2025
Contributor
|
Workflow has started. The target step completed with status: cancelled. |
hardcoretime
force-pushed
the
feat/vd/remove-finalizer-from-unmounted-vd
branch
from
fecc90c to
8161ffb
Compare
LopatinDmitr
previously approved these changes
May 7, 2025
Contributor
|
Workflow has started. The target step completed with status: failure. |
`vd-protection` will be removed from the virtual disk if the virtual machine is stopped. Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
hardcoretime
force-pushed
the
feat/vd/remove-finalizer-from-unmounted-vd
branch
from
8161ffb to
310da17
Compare
Contributor
|
Workflow has started. The target step completed with status: failure. |
LopatinDmitr
approved these changes
May 12, 2025
Merged
yachmenevas
pushed a commit
that referenced
this pull request
Oct 15, 2025
`vd-protection` will be removed from the virtual disk if the virtual machine is stopped. Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
vd-protectionwill be removed from the virtual disk if the virtual machine is stopped.Why do we need it, and what problem does it solve?
This is necessary for the new feature, 'Restore Virtual Machine with Force Option.' Before restoring the virtual machine, it should be stopped to restore the virtual disk.
What is the expected result?
Checklist
Changelog entries