Skip to content

fix(vm): fix condition based metrics#1069

Merged
Isteb4k merged 1 commit into
mainfrom
fix/vm/fix-condition-based-metrics
May 20, 2025
Merged

fix(vm): fix condition based metrics#1069
Isteb4k merged 1 commit into
mainfrom
fix/vm/fix-condition-based-metrics

Conversation

@Isteb4k

@Isteb4k Isteb4k commented May 20, 2025

Copy link
Copy Markdown
Contributor

Description

AwaitingRestartToApplyConfiguration, ConfigurationApplied, AgentReady and FirmwareUpToDate conditions are no longer displayed to the user unless they contain an issue or some important message for the user. However, this change was not accounted for in the metrics. It's fixed in this pr.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm 
type: fix
summary: The collection of metrics based on conditions has been fixed. `AwaitingRestartToApplyConfiguration`, `ConfigurationApplied`, `AgentReady` and `FirmwareUpToDate` conditions of the virtual machine are no longer displayed to the user unless they contain an issue or an important message. However, this change was not initially reflected in the metrics. It has now been corrected.

Signed-off-by: Isteb4k <dmitry.rakitin@flant.com>
@Isteb4k Isteb4k marked this pull request as ready for review May 20, 2025 14:19
@Isteb4k Isteb4k requested a review from yaroslavborbat as a code owner May 20, 2025 14:19
@Isteb4k Isteb4k requested review from danilrwx and removed request for yaroslavborbat May 20, 2025 14:19
@Isteb4k Isteb4k added this to the v0.18.1 milestone May 20, 2025
@Isteb4k Isteb4k merged commit 56cf15f into main May 20, 2025
25 of 28 checks passed
@Isteb4k Isteb4k deleted the fix/vm/fix-condition-based-metrics branch May 20, 2025 14:36
@Isteb4k

Isteb4k commented May 20, 2025

Copy link
Copy Markdown
Contributor Author

/backport 0.18

github-actions Bot pushed a commit that referenced this pull request May 20, 2025
AwaitingRestartToApplyConfiguration, ConfigurationApplied, AgentReady and FirmwareUpToDate conditions are no longer displayed to the user unless they contain an issue or some important message for the user. However, this change was not accounted for in the metrics. It's fixed in this pr.

Signed-off-by: Isteb4k <dmitry.rakitin@flant.com>
deckhouse-BOaTswain added a commit that referenced this pull request May 20, 2025
fix(vm): fix condition based metrics (#1069)

AwaitingRestartToApplyConfiguration, ConfigurationApplied, AgentReady and FirmwareUpToDate conditions are no longer displayed to the user unless they contain an issue or some important message for the user. However, this change was not accounted for in the metrics. It's fixed in this pr.

Signed-off-by: Isteb4k <dmitry.rakitin@flant.com>
Co-authored-by: Dmitry Rakitin <dmitry.rakitin@flant.com>
@deckhouse-BOaTswain

Copy link
Copy Markdown
Contributor

Cherry pick PR 1071 to the branch release-0.18 successful!

yachmenevas pushed a commit that referenced this pull request Oct 15, 2025
AwaitingRestartToApplyConfiguration, ConfigurationApplied, AgentReady and FirmwareUpToDate conditions are no longer displayed to the user unless they contain an issue or some important message for the user. However, this change was not accounted for in the metrics. It's fixed in this pr.

Signed-off-by: Isteb4k <dmitry.rakitin@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants