test: skip StorageClassMigration when VD Migration Controller reverts volume migration#2117
Merged
universal-itengineer merged 5 commits intoMar 26, 2026
Merged
Conversation
5b1cf21 to
e5ef26d
Compare
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
e5ef26d to
c9605ae
Compare
c9605ae to
c429b25
Compare
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
0eceb75 to
a5fed38
Compare
yaroslavborbat
approved these changes
Mar 26, 2026
danilrwx
pushed a commit
that referenced
this pull request
Mar 27, 2026
… volume migration (#2117) Description Skip StorageClassMigration e2e tests when VD Migration Controller reverts volume migration. --------- Signed-off-by: Nikita Korolev <nikita.korolev@flant.com> Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Skip StorageClassMigration e2e tests when VD Migration Controller reverts volume migration.
Changes:
SkipIfVDMigrationRevertedfunction intest/e2e/internal/util/vm.go: checksvd.Status.MigrationStateforResult=FailedwithMessage="Migration reverted."and skips the test if found.SkipIfVDMigrationRevertedcalls inside polling loops in:UntilVMMigrationSucceededuntilVirtualDisksMigrationsSucceededvolume_migration_storage_class_changed.goExpect(err).NotTo(HaveOccurred())withreturn errinsideEventually(func() error {...})callback to properly propagate errors instead of failing immediately.Why do we need it, and what problem does it solve?
VD Migration Controller may revert an in-progress volume migration for various reasons (VM not running, VM not migrating, etc.). When this happens, e2e tests polling for migration success wait until timeout and then fail, even though the migration was intentionally reverted by the controller. This creates flaky test failures unrelated to actual code defects.
What is the expected result?
During polling, if any VirtualDisk in the namespace has MigrationState.Result=Failed and MigrationState.Message="Migration reverted.", the test is immediately skipped with a clear message instead of waiting for timeout and failing.
Checklist
Changelog entries