feat(module): add annotations for kubevirt migration settings#2158
Merged
Conversation
4c72cb0 to
a115ed2
Compare
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
2f4846b to
b2a1f02
Compare
4 tasks
Isteb4k
approved these changes
Mar 25, 2026
Isteb4k
pushed a commit
that referenced
this pull request
Mar 30, 2026
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com> (cherry picked from commit 27f0a68)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced the standalone
parallel-outbound-migrations-per-nodehook with a unifiedmigration-confighook that manages all KubeVirt migration parameters viaModuleConfigannotations.New configurable parameters (via
ModuleConfigannotations):virtualization.deckhouse.io/bandwidth-per-migration(default:640Mi)virtualization.deckhouse.io/completion-timeout-per-gib(default:800)virtualization.deckhouse.io/parallel-outbound-migrations-per-node(default:1)virtualization.deckhouse.io/progress-timeout(default:150)Why do we need it, and what problem does it solve?
Previously only
parallelOutboundMigrationsPerNodewas configurable via aModuleConfigannotation; the rest of the migration parameters (bandwidthPerMigration,completionTimeoutPerGiB,progressTimeout) were hardcoded in the Helm template. This made it impossible to tune migration performance without patching the module.The single-parameter hook also duplicated the same pattern (watch
ModuleConfigannotations → write tovalues) that would need to be repeated for every new parameter.This change unifies all annotation-driven migration settings into one hook and makes the Helm template driven by
values, giving operators a clean, documented way to adjust migration performance per cluster.What is the expected result?
ModuleConfigfor thevirtualizationmodule, e.g.:migration-confighook fires and updates the internal values.KubeVirtCR reflects the new migration settings after Helm re-applies.Checklist
Changelog entries