feat(images): fetch TLS certificate from secret for upload endpoints#2235
Merged
Conversation
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Contributor
|
Workflow has started. The target step completed with status: failure. |
Contributor
|
Workflow has started. The target step completed with status: failure. |
LopatinDmitr
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added TLS certificate retrieval from secrets for upload endpoints to fix TLS verification errors when using self-signed certificates.
Why do we need it, and what problem does it solve?
When the cluster uses a self-signed certificate for the ingress controller, the IsUploaderReady function fails with TLS verification error because it doesn't have access to the TLS secret containing the CA certificate. This prevents users from uploading images through the upload endpoint.
The fix retrieves the TLS secret from the cluster and passes it to the IsUploaderReady function, enabling proper TLS verification.
What is the expected result?
Upload endpoints work correctly with TLS verification, even when the ingress controller uses self-signed certificates. The implementation also supports legacy naming of TLS secrets for backward compatibility.
Checklist