test(vm): add disk attachment test using new framework#2288
Merged
Conversation
hardcoretime
force-pushed
the
test/vm/add-disk-attachment-test
branch
from
b040adb to
ca74781
Compare
hardcoretime
changed the title
LopatinDmitr
previously approved these changes
Apr 28, 2026
Add new e2e test for hot attach/detach virtual disk to running VM. This test replaces the legacy vm_disk_attachment test with a more maintainable approach using object builders and framework helpers. - Remove legacy test with kustomize overlays - Add helper functions for VMBDA to legacy image_hotplug test - Remove vmDiskAttachment from test config Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
hardcoretime
force-pushed
the
test/vm/add-disk-attachment-test
branch
from
ca74781 to
b117a4f
Compare
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
hardcoretime
force-pushed
the
test/vm/add-disk-attachment-test
branch
from
b117a4f to
916f88c
Compare
LopatinDmitr
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrating e2e test DiskAttachment from legacy approach to the new framework.
The test verifies that virtual disks can be attached to and detached from running VMs.
Technical changes:
Why do we need it, and what problem does it solve?
According to the roadmap, all legacy e2e tests need to be gradually migrated to the new framework. This simplifies test code, makes them more declarative, and faster by using direct API calls instead of kubectl.
What is the expected result?
The DiskAttachment test passes successfully and verifies that virtual disks can be attached to and detached from running VMs, with disk count verified via lsblk.
Checklist
Changelog entries