test: fix external connectivity#2313
Merged
Merged
Conversation
hardcoretime
previously approved these changes
May 4, 2026
Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
589da29 to
13811f1
Compare
hardcoretime
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the e2e external connectivity check so it validates outbound connectivity instead of requiring a specific HTTP status from a single website.
Why do we need it, and what problem does it solve?
The previous
CheckExternalConnectivityimplementation treated external connectivity as a successfulcurlresponse with HTTP 200 from one hardcoded host. This made the test flaky and semantically incorrect: the VM could still have outbound network connectivity while the selected website was unavailable, redirected, or returned a non-200 status.This change makes the check align with the actual test intent. The VM is now considered externally connected if it can successfully reach at least one host from a fallback list within bounded timeouts.
What is the expected result?
CheckExternalConnectivity.Checklist
Changelog entries