test: quote focus/label args in e2e precheck prepare#2318
Merged
Conversation
…pare Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
hardcoretime
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
test/e2eprecheck prepare scripts: passFOCUS/LABELSto ginkgo with proper quoting (values may contain spaces).Why do we need it, and what problem does it solve?
When
FOCUScontains spaces,precheck:preparecould fail to generate/tmp/e2e-specs.json, causingSynchronizedBeforeSuiteto fail early.What is the expected result?
Focused e2e runs with
FOCUScontaining spaces complete precheck preparation and do not fail due to missing/tmp/e2e-specs.json.Steps:
FOCUS='when changes are applied manually' task -d test/e2e precheck:prepareFOCUS='when changes are applied manually' task -d test/e2e runChecklist
Changelog entries