Skip to content

test: quote focus/label args in e2e precheck prepare#2318

Merged
yaroslavborbat merged 1 commit into
mainfrom
fix/precheck-test
May 5, 2026
Merged

test: quote focus/label args in e2e precheck prepare#2318
yaroslavborbat merged 1 commit into
mainfrom
fix/precheck-test

Conversation

@yaroslavborbat

@yaroslavborbat yaroslavborbat commented May 5, 2026

Copy link
Copy Markdown
Member

Description

Fix test/e2e precheck prepare scripts: pass FOCUS/LABELS to ginkgo with proper quoting (values may contain spaces).

Why do we need it, and what problem does it solve?

When FOCUS contains spaces, precheck:prepare could fail to generate /tmp/e2e-specs.json, causing SynchronizedBeforeSuite to fail early.

What is the expected result?

Focused e2e runs with FOCUS containing spaces complete precheck preparation and do not fail due to missing /tmp/e2e-specs.json.

Steps:

  • FOCUS='when changes are applied manually' task -d test/e2e precheck:prepare
  • FOCUS='when changes are applied manually' task -d test/e2e run

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: test
type: fix
summary: "Fix e2e precheck prepare for focus/label filters containing spaces."
impact_level: low

…pare

Signed-off-by: Yaroslav Borbat <yaroslav.borbat@flant.com>
@yaroslavborbat yaroslavborbat requested a review from Isteb4k as a code owner May 5, 2026 10:03
@yaroslavborbat yaroslavborbat changed the title fix(test): handle focus/label filters with spaces in e2e precheck pre… fix(test): quote focus/label args in e2e precheck prepare May 5, 2026
@yaroslavborbat yaroslavborbat added this to the v1.9.0 milestone May 5, 2026
@hardcoretime hardcoretime changed the title fix(test): quote focus/label args in e2e precheck prepare test: quote focus/label args in e2e precheck prepare May 5, 2026
@yaroslavborbat yaroslavborbat merged commit 23794e0 into main May 5, 2026
34 of 38 checks passed
@yaroslavborbat yaroslavborbat deleted the fix/precheck-test branch May 5, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants