test: add PostCleanup precheck#2320
Merged
Merged
Conversation
added 5 commits
May 5, 2026 18:06
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
LopatinDmitr
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add PostCleanup precheck to the e2e test framework and integrate it with the Config struct.
Changes include:
IsCleanupNeededfield toConfigstruct intest/e2e/internal/config/config.goisCleanupNeeded: trueintest/e2e/default_config.yamlpostcleanupprecheck intest/e2e/internal/precheck/postcleanup.gothat validates thePOST_CLEANUPenvironment variablePrecheckPostCleanuplabel totest/e2e/internal/precheck/labels.goconf.IsCleanupNeededinstead of the oldconfig.IsCleanUpNeeded()functionframework.goandsuite_cvi.goto useGetConfig().IsCleanupNeededtest/e2e/README.mdto document the new configuration optionWhy do we need it, and what problem does it solve?
The e2e test framework previously used the
config.IsCleanUpNeeded()function that directly read thePOST_CLEANUPenvironment variable without considering the YAML configuration. This change:POST_CLEANUPenvironment variable before running testsWhat is the expected result?
POST_CLEANUP=noenvironment variable (takes precedence over YAML)isCleanupNeededfield indefault_config.yamlChecklist
Changelog entries