Skip to content

test(vd): wait for SSH before checking disk size after resize#2424

Merged
hardcoretime merged 1 commit into
mainfrom
fix/test/disk-resizing-ssh
Jun 1, 2026
Merged

test(vd): wait for SSH before checking disk size after resize#2424
hardcoretime merged 1 commit into
mainfrom
fix/test/disk-resizing-ssh

Conversation

@hardcoretime

@hardcoretime hardcoretime commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes the VirtualDiskResizing e2e test that fails with signal: killed error when executing SSH command sudo lsblk --nodeps --json -o SERIAL,SIZE after disk resize.

The test now includes util.UntilSSHReady(f, vm, framework.MiddleTimeout) before executing lsblk to verify the new disk sizes inside the VM.

Why do we need it, and what problem does it solve?

The VirtualDiskResizing e2e test was failing with the following error:

failed to execute command sudo lsblk --nodeps --json -o SERIAL,SIZE: signal: killed

The root cause is that after disk resize, the SSH connection can become temporarily unavailable. The test was executing lsblk immediately after the resize without waiting for SSH to become available again.

This fix adds a proper wait for SSH readiness after the resize operation, similar to how it's done before the resize.

What is the expected result?

The VirtualDiskResizing e2e test should pass consistently. The test now:

  1. Waits for VM to be running and SSH to be ready (existing)
  2. Gets initial disk sizes via lsblk (existing)
  3. Resizes the disks (existing)
  4. Waits for disks to become ready (existing)
  5. Waits for SSH to be ready (new)
  6. Gets new disk sizes via lsblk and verifies they increased (existing)

Checklist

  • The code is covered by unit tests (N/A - e2e test only)
  • e2e tests passed
  • Documentation updated according to the changes (N/A)
  • Changes were tested in the Kubernetes cluster manually

Changelog entries

section: test
type: fix
summary: "VirtualDiskResizing e2e test now waits for SSH before checking disk size after resize."
impact_level: low

After disk resize (hotplug), SSH connection can drop temporarily. The test
was executing lsblk immediately after resize, causing 'signal: killed' errors
when SSH wasn't available. Adding UntilSSHReady ensures the VM is accessible
before running lsblk.

Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
@hardcoretime hardcoretime requested a review from Isteb4k as a code owner June 1, 2026 11:59
@hardcoretime hardcoretime added this to the v1.9.0 milestone Jun 1, 2026
@hardcoretime hardcoretime merged commit b45d926 into main Jun 1, 2026
33 of 38 checks passed
@hardcoretime hardcoretime deleted the fix/test/disk-resizing-ssh branch June 1, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants