test(vd): wait for SSH before checking disk size after resize#2424
Merged
Conversation
After disk resize (hotplug), SSH connection can drop temporarily. The test was executing lsblk immediately after resize, causing 'signal: killed' errors when SSH wasn't available. Adding UntilSSHReady ensures the VM is accessible before running lsblk. Signed-off-by: Roman Sysoev <roman.sysoev@flant.com>
danilrwx
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the
VirtualDiskResizinge2e test that fails withsignal: killederror when executing SSH commandsudo lsblk --nodeps --json -o SERIAL,SIZEafter disk resize.The test now includes
util.UntilSSHReady(f, vm, framework.MiddleTimeout)before executinglsblkto verify the new disk sizes inside the VM.Why do we need it, and what problem does it solve?
The
VirtualDiskResizinge2e test was failing with the following error:The root cause is that after disk resize, the SSH connection can become temporarily unavailable. The test was executing
lsblkimmediately after the resize without waiting for SSH to become available again.This fix adds a proper wait for SSH readiness after the resize operation, similar to how it's done before the resize.
What is the expected result?
The
VirtualDiskResizinge2e test should pass consistently. The test now:Checklist
Changelog entries