Skip to content

chore(api): replace non-canonical annotation with the correct one#2428

Merged
eofff merged 3 commits into
mainfrom
chore/api/rename-internal-anno-prefix
Jun 17, 2026
Merged

chore(api): replace non-canonical annotation with the correct one#2428
eofff merged 3 commits into
mainfrom
chore/api/rename-internal-anno-prefix

Conversation

@eofff

@eofff eofff commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Description

Renamed the internal annotation API group prefix in annotations.go from virt.deckhouse.io to internal.virtualization.deckhouse.io.
Also updated 3p-containerized-data-importer in build/components/versions.yml to chore/rename-deckhouse-anno-prefix to keep dependency behavior aligned with the prefix change.

Why do we need it, and what problem does it solve?

The previous annotation prefix looked like a public-facing API domain. This change makes the namespace explicitly internal and aligns the CDI dependency branch to avoid annotation-prefix mismatches across components.

What is the expected result?

Annotations produced by the controller now use the internal.virtualization.deckhouse.io/* prefix.
Builds consume the CDI branch that includes the same annotation-prefix rename.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@eofff eofff changed the title change anno chore(api): fix: replace non-canonical annotation with the correct one Jun 2, 2026
@eofff eofff changed the title chore(api): fix: replace non-canonical annotation with the correct one chore(api): replace non-canonical annotation with the correct one Jun 2, 2026
@eofff eofff requested a review from loktev-d June 2, 2026 09:23
@eofff eofff marked this pull request as ready for review June 2, 2026 09:23
@eofff eofff added this to the v1.9.0 milestone Jun 2, 2026
@universal-itengineer universal-itengineer modified the milestones: v1.9.0, v1.10.0 Jun 10, 2026
@eofff eofff force-pushed the chore/api/rename-internal-anno-prefix branch 4 times, most recently from 5438dc8 to 9099b3c Compare June 16, 2026 08:06
Valeriy Khorunzhin added 3 commits June 16, 2026 16:51
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@eofff eofff force-pushed the chore/api/rename-internal-anno-prefix branch from 478466c to 491808d Compare June 16, 2026 13:51
@eofff eofff merged commit 04a57db into main Jun 17, 2026
31 of 32 checks passed
@eofff eofff deleted the chore/api/rename-internal-anno-prefix branch June 17, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants