fix(vd,vi): fix issues with storage class condition display#947
Merged
Conversation
Isteb4k
force-pushed
the
fix/vd/storage-class-ready
branch
from
504b7c2 to
2ad4caa
Compare
Isteb4k
changed the base branch from
main
to
fix/vi/handle-mc-vi-default-storage-class
Isteb4k
changed the title
Isteb4k
force-pushed
the
fix/vd/storage-class-ready
branch
from
2ad4caa to
a777604
Compare
Isteb4k
force-pushed
the
fix/vd/storage-class-ready
branch
5 times, most recently
from
25b38db to
ceb467f
Compare
Isteb4k
force-pushed
the
fix/vd/storage-class-ready
branch
from
ceb467f to
cf40143
Compare
hardcoretime
force-pushed
the
fix/vi/handle-mc-vi-default-storage-class
branch
from
5612507 to
f336835
Compare
Isteb4k
force-pushed
the
fix/vd/storage-class-ready
branch
from
cf40143 to
d4d96e8
Compare
Base automatically changed from
fix/vi/handle-mc-vi-default-storage-class
to
main
April 21, 2025 08:41
Isteb4k
force-pushed
the
fix/vd/storage-class-ready
branch
2 times, most recently
from
47adff2 to
0edd300
Compare
Signed-off-by: Isteb4k <dmitry.rakitin@flant.com>
Isteb4k
force-pushed
the
fix/vd/storage-class-ready
branch
from
0edd300 to
bdeb918
Compare
hardcoretime
approved these changes
Apr 22, 2025
Merged
yachmenevas
pushed a commit
that referenced
this pull request
Oct 15, 2025
1. The Start and StartImmediate methods of DiskService now take a *storagev1.StorageClass instead of a string as the storage class parameter. 2. The global services VirtualImageStorageClassService and VirtualDiskStorageClassService have been moved to the internal/service package of the corresponding resource. 3. All checks related to StorageClass are now performed exclusively in the StorageClassReady handlers. The LifeCycle handler (and all source handlers) now rely on the StorageClassReady condition and no longer perform redundant checks. 4. A new service, BaseStorageClassService, which integrates internal storage class services in order to use the base logic for working with StorageClass. 5. Refactored LifeCycle for vi similarly to how it’s done for vd. Signed-off-by: Isteb4k <dmitry.rakitin@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
StartandStartImmediatemethods ofDiskServicenow take a*storagev1.StorageClassinstead of astringas the storage class parameter.The global services
VirtualImageStorageClassServiceandVirtualDiskStorageClassServicehave been moved to the internal/service package of the corresponding resource.All checks related to
StorageClassare now performed exclusively in theStorageClassReadyhandlers. TheLifeCyclehandler (and all source handlers) now rely on theStorageClassReadycondition and no longer perform redundant checks.A new service,
BaseStorageClassService, which integrates internal storage class services in order to use the base logic for working withStorageClass.Refactored
LifeCyclefor vi similarly to how it’s done for vd.Checklist
Changelog entries