Skip to content

fix(vm): fix display BlockDeviceReady condition's message#949

Merged
LopatinDmitr merged 1 commit into
mainfrom
fix/vm/fix-display-condition-message
Apr 23, 2025
Merged

fix(vm): fix display BlockDeviceReady condition's message#949
LopatinDmitr merged 1 commit into
mainfrom
fix/vm/fix-display-condition-message

Conversation

@LopatinDmitr
Copy link
Copy Markdown
Contributor

@LopatinDmitr LopatinDmitr commented Apr 20, 2025

Description

This pull request refactors the handling of block device conditions within the VM controller.

  • Message Generation Simplification:

    • Consolidated message generation for disk states by removing redundant functions and using a closure addUsageMessage to handle single and multiple disk scenarios more concisely.
  • Issue Fix:

    • Corrected the issue where a stopped VM with a single disk incorrectly displayed the BlockDevicesReady status as False.

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm
type: fix
summary: Improve BlockDevicesReady's condition message
impact_level: low

@LopatinDmitr LopatinDmitr force-pushed the fix/vm/fix-display-condition-message branch from ecf1da6 to a77ac36 Compare April 20, 2025 20:17
@LopatinDmitr LopatinDmitr added this to the v0.17.0 milestone Apr 20, 2025
@LopatinDmitr LopatinDmitr force-pushed the fix/vm/fix-display-condition-message branch from a77ac36 to 19261fc Compare April 21, 2025 07:43
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr LopatinDmitr force-pushed the fix/vm/fix-display-condition-message branch from 19261fc to f00e8ea Compare April 22, 2025 12:14
@LopatinDmitr LopatinDmitr added the e2e/run Run e2e test on cluster of PR author label Apr 22, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Apr 22, 2025
@LopatinDmitr LopatinDmitr added the e2e/run Run e2e test on cluster of PR author label Apr 22, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Apr 22, 2025
@LopatinDmitr LopatinDmitr added the e2e/run Run e2e test on cluster of PR author label Apr 22, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Apr 22, 2025
@LopatinDmitr LopatinDmitr marked this pull request as ready for review April 22, 2025 18:24
@LopatinDmitr LopatinDmitr requested a review from Isteb4k as a code owner April 22, 2025 18:24
@LopatinDmitr LopatinDmitr merged commit 591a505 into main Apr 23, 2025
132 of 161 checks passed
@LopatinDmitr LopatinDmitr deleted the fix/vm/fix-display-condition-message branch April 23, 2025 07:57
yachmenevas pushed a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants