Skip to content

fix golangci-lint#970

Merged
universal-itengineer merged 20 commits into
mainfrom
fix/ci/go-linter-for-dirs
Jun 3, 2025
Merged

fix golangci-lint#970
universal-itengineer merged 20 commits into
mainfrom
fix/ci/go-linter-for-dirs

Conversation

@universal-itengineer
Copy link
Copy Markdown
Member

@universal-itengineer universal-itengineer commented Apr 23, 2025 •
edited
Loading

Description

Fix golangci-lint for virtualization-artifact
Skip lint for dirs:

  • ./images/cdi-cloner/cloner-startup
  • ./images/dvcr-artifact
  • ./tests/performance/shatal

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: ci
type: fix
summary: fix golangci-lint
impact_level: low

@universal-itengineer universal-itengineer added this to the v0.18.0 milestone Apr 23, 2025
@universal-itengineer universal-itengineer force-pushed the fix/ci/go-linter-for-dirs branch 7 times, most recently from 72614fb to 9a11841 Compare April 24, 2025 10:39
@universal-itengineer universal-itengineer modified the milestones: v0.18.0, v0.19.0 May 12, 2025
@Isteb4k Isteb4k modified the milestones: v0.19.0, v0.20.0 May 29, 2025
@universal-itengineer universal-itengineer force-pushed the fix/ci/go-linter-for-dirs branch 4 times, most recently from 573a7fb to 298ca9b Compare June 3, 2025 06:54
@universal-itengineer universal-itengineer marked this pull request as ready for review June 3, 2025 07:26
Isteb4k
Isteb4k requested changes Jun 3, 2025
View reviewed changes
Comment thread images/virtualization-artifact/pkg/controller/k8s-validation/validate-k8s-utils.go Outdated
*/

package k8s_validation
package k8s_validation //nolint:stylecheck // we don't care
Copy link
Copy Markdown
Contributor

@Isteb4k Isteb4k Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's delete all such comments

Comment thread images/virtualization-artifact/pkg/audit/events/vm/vm_event_log.go Outdated
Name string `json:"name"`
Datetime string `json:"datetime"`
Uid string `json:"uid"`
Uid string `json:"uid"` //nolint:stylecheck //TODO: fix
Copy link
Copy Markdown
Contributor

@Isteb4k Isteb4k Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this todo, we will not fix this

Comment thread images/virtualization-artifact/pkg/controller/vm/internal/class.go Outdated
}

//nolint:staticcheck
//nolint:staticcheck //TODO: fix
Copy link
Copy Markdown
Contributor

@Isteb4k Isteb4k Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this todo as well

Comment thread images/virtualization-artifact/pkg/controller/vm/internal/ipam.go Outdated
}

//nolint:staticcheck
//nolint:staticcheck //TODO: fix
Copy link
Copy Markdown
Contributor

@Isteb4k Isteb4k Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this todo pls

Comment thread images/virtualization-artifact/pkg/controller/vmclass/internal/util.go Outdated

func addAllUnknown(class *virtv2.VirtualMachineClass, conds ...vmclasscondition.Type) (update bool) {
//nolint:staticcheck
//nolint:staticcheck //TODO: use direct SetCondition instead conditions.NewManage
Copy link
Copy Markdown
Contributor

@Isteb4k Isteb4k Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this todo pls

Comment thread .github/workflows/dev_module_build.yml Outdated
echo -e "✅ All check passed\n"
fi

# if [ $find_errors -ne 0 ]; then
Copy link
Copy Markdown
Contributor

@Isteb4k Isteb4k Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this comment

@universal-itengineer universal-itengineer force-pushed the fix/ci/go-linter-for-dirs branch 2 times, most recently from a42d89e to 7036ff5 Compare June 3, 2025 14:49
@universal-itengineer
fix golangci-lint
c3963ed 
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>

add current branch for debug

Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>

add true

Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>

add dbg

Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>

add continue on error

Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>

add print

Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>

some fix

Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>

rm some echo

Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>

fix yaml format

Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>

change output

Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>

fix show errors

Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>

fix error

Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>

fix output

Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>

add dbg msg

Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer
rm changes
db3bae5 
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer
run golint
cfdbc02 
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer
fix - is unused
dbdf2f8 
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer
add comments to fix linter issues
25fd426 
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer
add more fixes
39ad592 
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer
rename NewCPUCountValidator
9ed66f0 
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer
remove unused funcs
97ef28e 
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer
fix some +1
4a0f8f1 
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer
fix all step1
6c27118 
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer
fix all +2
1bb6580 
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer
fix all +3
ee0c87e 
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer
fix ci
56a1cb4 
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer
test build with cacheVersion 03-06-2025.0
48cdb3e 
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer
add dirs for skip
bc66362 
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer
rm cacheVersion
ab52167 
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer
fix comments
c1ae2be 
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer
fix coment for nolint
10d2627 
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer
rm comment code in ci
f9c1c86 
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer
remove test branch
848d4a2 
Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
@universal-itengineer universal-itengineer force-pushed the fix/ci/go-linter-for-dirs branch from ef6d5ff to 848d4a2 Compare June 3, 2025 14:57
@universal-itengineer universal-itengineer merged commit 74bfade into main Jun 3, 2025
18 of 19 checks passed
@universal-itengineer universal-itengineer deleted the fix/ci/go-linter-for-dirs branch June 3, 2025 15:00
yachmenevas pushed a commit that referenced this pull request Oct 15, 2025
@universal-itengineer
fix golangci-lint (#970)
e938770 
Fix golangci-lint for virtualization-artifact
Skip lint for dirs:

./images/cdi-cloner/cloner-startup
./images/dvcr-artifact
./tests/performance/shatal

---------

Signed-off-by: Nikita Korolev <nikita.korolev@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Isteb4k Isteb4k Isteb4k approved these changes

@LopatinDmitr LopatinDmitr Awaiting requested review from LopatinDmitr LopatinDmitr is a code owner

@yaroslavborbat yaroslavborbat Awaiting requested review from yaroslavborbat yaroslavborbat is a code owner

@nevermarine nevermarine Awaiting requested review from nevermarine nevermarine is a code owner

@fl64 fl64 Awaiting requested review from fl64

Assignees

@universal-itengineer universal-itengineer

Labels

None yet

Projects

None yet

Milestone

v0.20.0

Development

Successfully merging this pull request may close these issues.

2 participants

@universal-itengineer @Isteb4k