Skip to content

fix(vmip): fix double create VirtualMachineIPLease#976

Merged
LopatinDmitr merged 4 commits into
mainfrom
fix/vmip/fix-double-vmipl
Apr 28, 2025
Merged

fix(vmip): fix double create VirtualMachineIPLease#976
LopatinDmitr merged 4 commits into
mainfrom
fix/vmip/fix-double-vmipl

Conversation

@LopatinDmitr
Copy link
Copy Markdown
Contributor

@LopatinDmitr LopatinDmitr commented Apr 24, 2025

Description

This pull request addresses a critical issue where VirtualMachineIPAddressLease was being created twice during the reconciliation process.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vmip
type: fix
summary: Fixed double creation of VirtualMachineIPAddressLease
impact_level: low

@LopatinDmitr LopatinDmitr added this to the v0.18.0 milestone Apr 24, 2025
@LopatinDmitr LopatinDmitr force-pushed the fix/vmip/fix-double-vmipl branch from 2d01967 to 976565f Compare April 24, 2025 19:07
@LopatinDmitr LopatinDmitr added the e2e/run Run e2e test on cluster of PR author label Apr 24, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Apr 24, 2025
@LopatinDmitr LopatinDmitr force-pushed the fix/vmip/fix-double-vmipl branch from 976565f to 872c290 Compare April 24, 2025 19:57
@LopatinDmitr LopatinDmitr added the e2e/run Run e2e test on cluster of PR author label Apr 24, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Apr 24, 2025
@LopatinDmitr LopatinDmitr marked this pull request as ready for review April 25, 2025 07:17
@LopatinDmitr LopatinDmitr marked this pull request as draft April 25, 2025 09:06
@LopatinDmitr LopatinDmitr force-pushed the fix/vmip/fix-double-vmipl branch 2 times, most recently from e0f8838 to 6915a5e Compare April 25, 2025 11:26
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr LopatinDmitr force-pushed the fix/vmip/fix-double-vmipl branch from 6915a5e to 423bf07 Compare April 25, 2025 12:00
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr LopatinDmitr marked this pull request as ready for review April 25, 2025 14:21
@LopatinDmitr LopatinDmitr added the e2e/run Run e2e test on cluster of PR author label Apr 25, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Apr 25, 2025
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@LopatinDmitr LopatinDmitr added the e2e/run Run e2e test on cluster of PR author label Apr 25, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Apr 25, 2025
@LopatinDmitr LopatinDmitr merged commit 33ef35b into main Apr 28, 2025
63 of 64 checks passed
@LopatinDmitr LopatinDmitr deleted the fix/vmip/fix-double-vmipl branch April 28, 2025 08:29
@Isteb4k Isteb4k removed this from the v0.18.0 milestone Apr 28, 2025
@Isteb4k Isteb4k added this to the v0.17.0 milestone Apr 28, 2025
@Isteb4k
Copy link
Copy Markdown
Contributor

Isteb4k commented Apr 28, 2025

/backport 0.17

github-actions Bot pushed a commit that referenced this pull request Apr 28, 2025
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
@deckhouse-BOaTswain
Copy link
Copy Markdown
Contributor

Failure: Cherry pick PR was created but cannot be merged

@nevermarine
Copy link
Copy Markdown
Collaborator

/backport 0.17

@deckhouse-BOaTswain
Copy link
Copy Markdown
Contributor

Backport failed. See Job for details.

@nevermarine
Copy link
Copy Markdown
Collaborator

/backport 0.17

deckhouse-BOaTswain added a commit that referenced this pull request Apr 28, 2025
fix(vmip): fix double create VirtualMachineIPLease (#976)

Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
Co-authored-by: Dmitry Lopatin <93423466+LopatinDmitr@users.noreply.github.com>
@deckhouse-BOaTswain
Copy link
Copy Markdown
Contributor

Cherry pick PR 987 to the branch release-0.17 successful!

yachmenevas pushed a commit that referenced this pull request Oct 15, 2025
Signed-off-by: Dmitry Lopatin <dmitry.lopatin@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants