Skip to content

tests: fix migration cancel test #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaroslavborbat merged 1 commit into from
Apr 28, 2025
Merged

tests: fix migration cancel test #977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions tests/e2e/vm_migration_cancel_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package e2e

import (
"fmt"
"slices"
"time"

. "github.com/onsi/ginkgo/v2"
Expand Down Expand Up @@ -161,6 +162,13 @@ var _ = Describe("Virtual machine migration cancel", SIGMigration(), ginkgoutil.
Expect(someCompleted).Should(BeFalse())

By("Abort status should be exists in Kubevirt VMIs")

validAbortStatuses := []virtv1.MigrationAbortStatus{
virtv1.MigrationAbortInProgress,
virtv1.MigrationAbortSucceeded,
virtv1.MigrationAbortFailed,
}

Eventually(func() error {
kvvmis := &virtv1.VirtualMachineInstanceList{}
err = GetObjects(kc.ResourceKubevirtVMI, kvvmis, kc.GetOptions{Labels: testCaseLabel, Namespace: conf.Namespace})
Expand All @@ -169,18 +177,23 @@ var _ = Describe("Virtual machine migration cancel", SIGMigration(), ginkgoutil.
}
for _, kvvmi := range kvvmis.Items {
migrationState := kvvmi.Status.MigrationState

if migrationState == nil {
return fmt.Errorf("retry because migration state is nil")
}
if !migrationState.AbortRequested {
return fmt.Errorf("retry because migration abort requested is false")
}
validAbortStatus := migrationState.AbortStatus == virtv1.MigrationAbortFailed || migrationState.AbortStatus == virtv1.MigrationAbortSucceeded
if !validAbortStatus {

if !slices.Contains(validAbortStatuses, migrationState.AbortStatus) {
return fmt.Errorf("retry because migration abort status is %s", migrationState.AbortStatus)
}

if migrationState.EndTimestamp.IsZero() {
return fmt.Errorf("retry because migration is not finished yet")
}
}
return nil
}).WithTimeout(MaxWaitTimeout).WithPolling(time.Second).ShouldNot(HaveOccurred())
}).WithTimeout(LongWaitDuration).WithPolling(time.Second).ShouldNot(HaveOccurred())
})
})
Loading