Skip to content

feat(vmsnapshot): add resources info in status#978

Merged
eofff merged 8 commits into
mainfrom
feat/vmsnapshot/add-resources-description
Apr 30, 2025
Merged

feat(vmsnapshot): add resources info in status#978
eofff merged 8 commits into
mainfrom
feat/vmsnapshot/add-resources-description

Conversation

@eofff
Copy link
Copy Markdown
Contributor

@eofff eofff commented Apr 25, 2025 •
edited by Isteb4k
Loading

Description

Show resources list in vmsnapshot status.

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vmsnapshot
type: feature
summary: The status of the VirtualMachineSnapshot resource now displays information about the resources included in the snapshot.

@eofff eofff requested review from fl64 and removed request for fl64 April 25, 2025 13:49
@eofff eofff force-pushed the feat/vmsnapshot/add-resources-description branch 3 times, most recently from 3f5cc29 to e06026d Compare April 28, 2025 15:38
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Apr 28, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Apr 28, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Apr 28, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Apr 28, 2025
@eofff eofff force-pushed the feat/vmsnapshot/add-resources-description branch 3 times, most recently from be229d9 to 2ff2909 Compare April 29, 2025 08:27
@eofff eofff changed the title add feat(vmsnapshot): add resources info in status Apr 29, 2025
@eofff eofff added this to the v0.18.0 milestone Apr 29, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Apr 29, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Apr 29, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Apr 29, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Apr 29, 2025
@eofff eofff force-pushed the feat/vmsnapshot/add-resources-description branch from e4d8ee7 to 2a15f49 Compare April 29, 2025 12:01
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Apr 29, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Apr 29, 2025
@eofff eofff marked this pull request as ready for review April 29, 2025 12:45
@eofff eofff force-pushed the feat/vmsnapshot/add-resources-description branch from 2a15f49 to 8bbadf4 Compare April 29, 2025 12:45
@z9r5 z9r5 requested a review from maxinsky April 30, 2025 07:34
maxinsky
maxinsky previously approved these changes Apr 30, 2025
View reviewed changes
z9r5
z9r5 previously approved these changes Apr 30, 2025
View reviewed changes
LopatinDmitr
LopatinDmitr reviewed Apr 30, 2025
View reviewed changes
Comment thread api/core/v1alpha2/virtual_machine_snapshot.go Outdated
LopatinDmitr
LopatinDmitr reviewed Apr 30, 2025
View reviewed changes
Comment thread images/virtualization-artifact/pkg/controller/vmsnapshot/internal/life_cycle_test.go Outdated
@eofff eofff dismissed stale reviews from z9r5 and maxinsky via 9c0d471 April 30, 2025 14:40
Valeriy Khorunzhin and others added 8 commits April 30, 2025 17:40
add
45ecc96 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
fix test
8cc283a 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
fix vm apiVersion
d71a905 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
add secret and vmip
53ba169 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
refactoring
28aa20e 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
doc
d580346 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@maxinsky
Minor description edits
757a947 
Signed-off-by: Max Chervov <max.chervov@gmail.com>
resolve
c5c1b06 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@eofff eofff force-pushed the feat/vmsnapshot/add-resources-description branch from 9c0d471 to c5c1b06 Compare April 30, 2025 14:40
@LopatinDmitr LopatinDmitr self-requested a review April 30, 2025 14:42
@eofff eofff merged commit 79c634a into main Apr 30, 2025
22 of 23 checks passed
@eofff eofff deleted the feat/vmsnapshot/add-resources-description branch April 30, 2025 15:00
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Apr 30, 2025
Merged
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request May 15, 2025
Merged
yachmenevas pushed a commit that referenced this pull request Oct 15, 2025
@eofff @maxinsky
feat(vmsnapshot): add resources info in status (#978)
ea59fca 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
Co-authored-by: Max Chervov <max.chervov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LopatinDmitr LopatinDmitr LopatinDmitr approved these changes

@z9r5 z9r5 z9r5 left review comments

@maxinsky maxinsky maxinsky left review comments

@Isteb4k Isteb4k Awaiting requested review from Isteb4k Isteb4k is a code owner

@yaroslavborbat yaroslavborbat Awaiting requested review from yaroslavborbat yaroslavborbat is a code owner

@fl64 fl64 Awaiting requested review from fl64 fl64 is a code owner

@goganat goganat Awaiting requested review from goganat goganat is a code owner

Assignees

@eofff eofff

Labels

None yet

Projects

None yet

Milestone

v0.18.0

Development

Successfully merging this pull request may close these issues.

5 participants

@eofff @z9r5 @maxinsky @LopatinDmitr @deckhouse-BOaTswain