Skip to content

Commit ab6ef21

Browse files
decobotclaude
andcommitted
refactor: remove forced Knative rollout on ACL provisioning
Sites pick up credentials on their next natural deploy — no need to force a new Revision immediately. This avoids unnecessary pod restarts across all sites during bootstrap. Also reduces Knative Services RBAC to read-only since update/patch are no longer needed. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
1 parent ae568d2 commit ab6ef21

3 files changed

Lines changed: 1 addition & 10 deletions

File tree

chart/templates/clusterrole-operator-manager-role.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,4 @@ rules:
7575
verbs:
7676
- get
7777
- list
78-
- patch
79-
- update
8078
- watch

config/rbac/role.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,4 @@ rules:
7676
verbs:
7777
- get
7878
- list
79-
- patch
80-
- update
8179
- watch

internal/controller/namespace_controller.go

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ const (
5353

5454
// +kubebuilder:rbac:groups="",resources=namespaces,verbs=get;list;watch;update;patch
5555
// +kubebuilder:rbac:groups="",resources=secrets,verbs=get;list;watch;create
56-
// +kubebuilder:rbac:groups=serving.knative.dev,resources=services,verbs=get;list;watch;update;patch
56+
// +kubebuilder:rbac:groups=serving.knative.dev,resources=services,verbs=get;list;watch
5757

5858
// DefaultResyncPeriod is the default interval at which the reconciler re-syncs
5959
// ACL users to all Valkey nodes even when nothing changed. Configurable via
@@ -291,11 +291,6 @@ func (r *NamespaceReconciler) Reconcile(ctx context.Context, req ctrl.Request) (
291291
valkeyTenantsProvisioned.Inc()
292292
log.Info("Valkey ACL provisioned", "user", siteName, "namespace", ns.Name)
293293

294-
// Trigger a new Knative Revision so running pods pick up the new Secret.
295-
if patchErr := r.patchKnativeServiceTimestamp(ctx, ns.Name); patchErr != nil {
296-
log.Error(patchErr, "Failed to patch Knative Service (non-fatal)")
297-
}
298-
299294
case err != nil:
300295
return ctrl.Result{}, fmt.Errorf("get secret: %w", err)
301296

0 commit comments

Comments
 (0)