deno lint -> oxlint (#1561)

* chore: update package scripts and dependencies

- Replaced `deno lint` with `oxlint` for linting.
- Adjusted script commands for consistency and clarity.
- Updated `bun.lockb` to reflect changes in dependencies.
- Refactored header merging logic in various components for improved readability.
- Enhanced regex patterns in multiple files for consistency in path matching.

These changes streamline the development process and improve code maintainability.

* chore(lint): add .oxlintrc.json configuration and update error handling

- Introduced a new `.oxlintrc.json` file to configure linting rules, specifically turning off the `no-unused-expressions` rule and ignoring certain patterns.
- Refactored error handling in various components to remove unused error parameters, improving code clarity and consistency.
- Updated `bun.lockb` to reflect dependency changes.

These updates enhance the linting process and improve the overall readability of the codebase.

* refactor(package): clean up package.json and improve error handling

- Removed unused compiler options and lint configuration from package.json, streamlining the file for better clarity.
- Updated error handling in the getAppUUID function to log the error object instead of a generic variable, enhancing debugging capabilities.

These changes improve the maintainability and readability of the codebase.

* fix(ai): improve metadata handling in AIAgent class

- Updated the metadata assignment in the AIAgent class to ensure proper handling of timings. This change enhances the clarity and maintainability of the code by explicitly spreading the existing metadata before adding new properties.

No functionality is broken; this update improves the robustness of the agent's context management.

* chore(lint): update linting rules and ignore patterns

- Added `no-explicit-any` and `ban-types` rules to `.oxlintrc.json` with warnings to improve type safety.
- Updated ignore patterns to include `docs/*` for better linting coverage.
- Replaced `deno-lint-ignore-file` comments with `oxlint-disable` for consistency across the codebase.

These changes enhance the linting process and promote better coding practices throughout the project.

* chore(lint): update lint ignore comments for consistency

- Replaced `deno-lint-ignore` comments with `oxlint-disable-next-line` across multiple files to standardize linting practices.
- This change improves code consistency and aligns with the updated linting rules established in previous commits.

* chore(lint): introduce kebab-case filename enforcement plugin

- Added a new linting rule to enforce kebab-case naming for filenames in the project, improving consistency in file naming conventions.
- Updated `.oxlintrc.json` to include the new rule and associated plugin, enhancing the linting configuration.
- Removed the old TypeScript implementation of the kebab-case rule in favor of the new JavaScript version for better compatibility with the current linting setup.

These changes promote better coding practices and maintainability across the codebase.

* chore(lint): reorganize linting rules in .oxlintrc.json

- Moved the linting rules section within `.oxlintrc.json` to improve clarity and organization.
- Retained existing rules such as `no-unused-expressions`, `no-explicit-any`, `enforce-kebab-case-file-names/kebab-case`, and `ban-types` to maintain code quality and consistency.

These adjustments enhance the readability of the linting configuration while preserving the established linting practices.

* chore(lint): remove Deno lint setup from CI workflow

- Eliminated the Deno setup step from the GitHub Actions workflow as linting has been fully migrated to Biome.
- Updated package.json to remove the deprecated Deno lint command, streamlining the linting process.

These changes enhance the CI configuration by removing unnecessary steps and aligning with the current linting practices.

* chore(lint): simplify handleLiteral function and update .oxlintrc.json

- Refactored the `handleLiteral` function in `ensure-tailwind-design-system-tokens.js` to use a more concise parameter destructuring syntax, improving code readability.
- Updated `.oxlintrc.json` to streamline the configuration by consolidating the `jsPlugins` array into a single line.

These changes enhance the clarity of the code and maintain consistency in the linting configuration.

* chore(lint): remove no-explicit-any rule from do-storage.ts

- Eliminated the `no-explicit-any` linting directive from `do-storage.ts` to align with updated linting practices.
- This change enhances code clarity by removing unnecessary linting comments and maintaining consistency across the codebase.

* chore(release): bump versions for cli and workers-runtime packages

- Updated the version of `deco-cli` from `0.22.4` to `0.22.5` to reflect recent changes.
- Incremented the version of `@deco/workers-runtime` from `0.23.1` to `0.23.2` for consistency with the latest updates.

These version bumps ensure that the packages are aligned with the latest developments in the codebase.

* chore(package): rename package from @deco/chat to @decocms/admin

- Updated the package name in package.json to reflect the new branding for the admin interface.
- This change aligns the package with the overall project structure and naming conventions.

* fix(spread): restore nullish coalescing in spread operations

- Reintroduced nullish coalescing in multiple spread operations across various files to ensure safe handling of potentially undefined values.
- Updated components and utility functions in `apps/web`, `packages/ai`, `packages/cli`, `packages/runtime`, and `packages/sdk` to maintain consistency and prevent runtime errors.

These changes enhance the robustness of the code by ensuring that undefined values do not lead to unintended behavior.

* refactor(spread): remove NULLISH_COALESCING_REMOVALS.md file

- Deleted the `NULLISH_COALESCING_REMOVALS.md` file, which documented the nullish coalescing removals from spread operations.
- This cleanup reflects the completion of the related refactoring work and helps maintain a tidy documentation structure.

No further action is required as the relevant changes have been implemented in the codebase.

* chore(lint): disable unicorn/no-useless-fallback-in-spread rule in .oxlintrc.json

- Turned off the `unicorn/no-useless-fallback-in-spread` rule in the linting configuration to prevent unnecessary warnings during development.
- This adjustment aligns the linting rules with current project needs and enhances the developer experience.

No further action is required as this change is purely a configuration update.

Author: viktormarinho

.github/workflows/test.yml

@@ -19,12 +19,6 @@ jobs:
       - name: Setup Bun
         uses: oven-sh/setup-bun@v2
 
-      # Remove when lint is migrated to Biome
-      - name: Set up Deno
-        uses: denoland/setup-deno@v2
-        with:
-          deno-version: v2.x
-
       - name: Install dependencies
         run: bun install
 

.oxlintrc.json

@@ -0,0 +1,15 @@
+{
+  "jsPlugins": ["./plugins/enforce-kebab-case-file-names.js"],
+  "ignorePatterns": [
+    "scripts/migrate-project-entity-table.ts",
+    "packages/sdk/src/observability/otel/*",
+    "docs/*"
+  ],
+  "rules": {
+    "unicorn/no-useless-fallback-in-spread": "off",
+    "no-unused-expressions": "off",
+    "no-explicit-any": "warn",
+    "enforce-kebab-case-file-names/kebab-case": "warn",
+    "ban-types": "warn"
+  }
+}

apps/api/main.ts

@@ -1,4 +1,4 @@
-// deno-lint-ignore-file no-explicit-any
+/* oxlint-disable no-explicit-any */
 export * from "./src/actors.ts";
 export { WorkspaceDatabase } from "./src/durable-objects/workspace-database.ts";
 // DECONFIG DurableObjects (re-exported from SDK)

apps/api/src/api.ts

@@ -150,7 +150,7 @@ export const honoCtxToAppCtx = (c: Context<AppEnv>): AppContext => {
 
 const mapMCPErrorToHTTPExceptionOrThrow = (err: Error) => {
   if ("code" in err) {
-    // deno-lint-ignore no-explicit-any
+    // oxlint-disable-next-line no-explicit-any
     const cause = (err as any as { detail?: unknown }).detail;
     const status = (err.code as ContentfulStatusCode | undefined) ?? 500;
     const message = err.message ?? "Internal server error";
@@ -472,9 +472,7 @@ const createMcpServerProxyForIntegration = async (
         policies: [{ statements }],
       });
     },
-    headers: {
-      ...(callerApp ? { "x-caller-app": callerApp } : {}),
-    },
+    headers: callerApp ? { "x-caller-app": callerApp } : {},
     tools: integration.tools
       ? { tools: integration.tools as ListToolsResult["tools"] }
       : undefined,

apps/api/src/auth/index.ts

@@ -120,7 +120,7 @@ export const createMagicLinkEmail = async (ctx: AppContext) => {
       },
     });
     return { email };
-  } catch (_) {
+  } catch {
     return { error: "" };
   }
 };
@@ -202,7 +202,7 @@ appLogin.all("/magiclink", async (ctx: AppContext) => {
       },
     });
     return ctx.json({ email });
-  } catch (_) {
+  } catch {
     return ctx.json({ error: "" }, 400);
   }
 });

apps/api/src/durable-objects/workspace-database.ts

@@ -16,7 +16,7 @@ export class WorkspaceDatabase
 
   constructor(
     // @ts-ignore: This is a workaround to fix the type error
-    // deno-lint-ignore ban-types
+    // oxlint-disable-next-line ban-types
     protected override ctx: DurableObjectState<{}>,
     protected override env: Bindings,
   ) {

apps/api/src/email.ts

@@ -17,7 +17,7 @@ import PostalMime from "postal-mime";
 
 const readContent = async (message: ForwardableEmailMessage) => {
   // Parse the MIME message to extract structured content
-  // deno-lint-ignore no-explicit-any
+  // oxlint-disable-next-line no-explicit-any
   const email = await PostalMime.parse(message.raw as any);
 
   // Return the text content, fallback to HTML if text is not available
@@ -34,7 +34,7 @@ export function email(
       c: Constructor,
     ) => StubFactory<InstanceType<Constructor>> = (c) => {
       return runtime instanceof ActorCfRuntime
-        ? // deno-lint-ignore no-explicit-any
+        ? // oxlint-disable-next-line no-explicit-any
           runtime.stub(c, env as any)
         : actors.stub(c.name);
     };

apps/api/src/middlewares/actors.ts

@@ -19,7 +19,7 @@ export const withActorsMiddleware: Handler<AppEnv> = async (ctx, next) => {
   ctx.set("immutableRes", true);
   startTime(ctx, "actor");
   return await actorsMiddleware(
-    // deno-lint-ignore no-explicit-any
+    // oxlint-disable-next-line no-explicit-any
     ctx as any,
     next,
   ).finally(() => endTime(ctx, "actor"));

apps/api/tail.ts

@@ -1,4 +1,4 @@
-// deno-lint-ignore-file no-explicit-any
+/* oxlint-disable no-explicit-any */
 
 // Interface for trace events from tail
 interface TailTrace {

apps/outbound/main.ts

@@ -93,7 +93,7 @@ export default {
         new Request(req.url, {
           method: req.method,
           headers: reqHeaders,
-          body: req.body,
+          ...(req.body ? { body: req.body } : {}),
           redirect: req.redirect,
         }),
       );