test(cms): regression test — site app entry detection on TanStack Start sites#4049
Open
JonasJesus42 wants to merge 1 commit into
Open
test(cms): regression test — site app entry detection on TanStack Start sites#4049JonasJesus42 wants to merge 1 commit into
JonasJesus42 wants to merge 1 commit into
Conversation
…rt sites TanStack Start's composeMeta does not register site/apps/site.ts in manifest.blocks.apps, causing findSiteAppEntry to return null for these sites. The canonical 'site' key is now trusted directly via isSiteAppBlock. This test documents and guards that behavior. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findSiteAppEntrycovering TanStack Start sites, where@decocms/start'scomposeMetadoes not populatemanifest.blocks.appsisSiteAppBlockinstead ofisResolvableManifestAppfor the canonicalsitekey); this PR guards against future regressionsRoot cause documented
TanStack Start's
generate-schema.tsonly emitsmanifest.blocks.sections.composeMetaadds pages/loaders/actions/matchers at runtime, but neverapps. As a resultisResolvableManifestApp(meta, "site/apps/site.ts")was returningfalseand the Studio's Site tab showed Site settings not found.The fix in #4012 (
isSiteAppBlockshort-circuit on the canonicalsitekey) is the correct behavior; the schema rendering is addressed on the site side via the companion PR inbaggagio-tanstack.Test plan
bun test apps/mesh/src/web/components/sections-editor/page-list.test.ts— 13 passGenerated with Claude Code
Summary by cubic
Add a regression test for findSiteAppEntry so TanStack Start sites resolve the site app even when manifest.blocks.apps is missing. This locks in the behavior that trusts the canonical "site" key and prevents the Studio Site tab from showing "Site settings not found".
Written for commit fd6fd98. Summary will update on new commits.