Skip to content

fix(security): restrict OAuth redirect_uri localhost bypass to local mode #4121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xcucumbersalad wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(security): restrict OAuth redirect_uri localhost bypass to local mode #4121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions apps/mesh/src/api/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,11 +421,13 @@ const oauthProxyHandler: MiddlewareHandler<Env> = async (c) => {
const redirectUrl = new URL(redirectUri);
const allowedOriginObj = new URL(allowedOrigin);

// Check if redirect_uri origin matches the allowed origin
// Check if redirect_uri origin matches the allowed origin.
// Localhost is only allowed in local mode — in production, an attacker
// could set redirect_uri=http://localhost:8080/steal to intercept
// OAuth authorization codes on shared hosts or cloud environments.
const isAllowed =
redirectUrl.origin === allowedOriginObj.origin ||
// Allow localhost for development
redirectUrl.hostname === "localhost";
(getSettings().localMode && redirectUrl.hostname === "localhost");

if (!isAllowed) {
return c.json(
Expand Down
Loading