Skip to content

Commit 143faf7

Browse files
🤖 backported "Relax schema in security center" (metabase#75390)
Relax schema in security center (metabase#75382) security center: relax semver schema Co-authored-by: Nicola Mometto <nicola.mometto@metabase.com>
1 parent 75616cb commit 143faf7

2 files changed

Lines changed: 19 additions & 1 deletion

File tree

enterprise/backend/src/metabase_enterprise/security_center/schema.clj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
[:string {:min 1}])
88

99
(mr/def ::semver
10-
[:re #"^\d+\.\d+\.\d+$"])
10+
[:re #"^\d+(?:\.\d+)*$"])
1111

1212
(mr/def ::severity
1313
[:enum :critical :high :medium :low])
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
(ns metabase-enterprise.security-center.schema-test
2+
(:require
3+
[clojure.test :refer :all]
4+
[metabase-enterprise.security-center.schema :as schema]
5+
[metabase.util.malli.registry :as mr]))
6+
7+
(set! *warn-on-reflection* true)
8+
9+
(deftest ^:parallel semver-test
10+
(testing "accepts versions with any number of dot-separated numeric segments"
11+
(doseq [v ["1.57" "1.57.19" "0.50.2" "1.58.14" "10.0.0"
12+
"1.57.19.1" "1.58.14.1" "1.57.19.1.2"]]
13+
(is (mr/validate ::schema/semver v)
14+
v)))
15+
(testing "rejects non-versions"
16+
(doseq [v ["1." ".1" "1..2" "foo" "1.57.x"]]
17+
(is (not (mr/validate ::schema/semver v))
18+
v))))

0 commit comments

Comments
 (0)