Skip to content

Commit cab72df

Browse files
committed
feat(ommsync)!: update ommclient2 version, uses SSL connection per default
BREAKING CHANGE: OMM client uses SSL by default now, existing configurations need to change the omm port and add the use_ssl option. To use SSL the ports needs to be set to 12622 SSL is supported on almost every OMM version OMM version >9 does not support unencrypted connections
1 parent 5c02be8 commit cab72df

4 files changed

Lines changed: 8 additions & 2 deletions

File tree

services/dect-wip-ommsync/dect-wip-ommsync.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ def init(config_path):
9494
client = mitel_ommclient2.OMMClient2(
9595
host=config.omm_ip,
9696
port=config.omm_port,
97+
use_ssl=config.omm_usessl,
9798
username=config.omm_username,
9899
password=config.omm_password,
99100
ommsync=True

services/dect-wip-ommsync/requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
mitel_ommclient2
1+
mitel_ommclient2 @ git+https://codeberg.org/TilCreator/mitel_ommclient2.git@main
22
rsa
33
flask
44
flask-apscheduler

systemfiles/etc/dect-wip.ini.sample

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,11 @@ show_voucher = False
1717

1818
[omm]
1919
ip = 10.10.10.10
20-
port = 12621
20+
port = 12622
21+
# To use SSL the ports needs to be set to 12622
22+
# SSL is supported on almost every OMM version
23+
# OMM version >9 does not support unencrypted connection
24+
use_ssl = true
2125
username = ade
2226
password = ade
2327

tools/confighelper.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,5 +76,6 @@ def __init__(self, config_path = '/etc/dect-wip.ini'):
7676
# [omm]
7777
self.omm_ip = self.__get_config_with_env_override('omm', 'ip')
7878
self.omm_port = int(self.__get_config_with_env_override('omm', 'port'))
79+
self.omm_use_ssl = str_to_bool(self.__get_config_with_env_override('omm', 'use_ssl'))
7980
self.omm_username = self.__get_config_with_env_override('omm', 'username')
8081
self.omm_password = self.__get_config_with_env_override('omm', 'password')

0 commit comments

Comments
 (0)