fix duplicate row_selection keyword in notebook grid

Author: deeleeramone

pywry/pywry/grid.py

@@ -1239,18 +1239,34 @@ def build_grid_config(  # pylint: disable=too-many-arguments
     elif isinstance(row_selection, dict):
         row_sel_dict = row_selection
 
+    # Normalize user-provided grid options and consume rowSelection aliases.
+    # This prevents duplicate keyword errors when both row_selection param and
+    # grid_options['rowSelection'] are present.
+    normalized_grid_options = dict(grid_options or {})
+    grid_opt_row_selection = normalized_grid_options.pop("rowSelection", None)
+    if grid_opt_row_selection is None and "row_selection" in normalized_grid_options:
+        grid_opt_row_selection = normalized_grid_options.pop("row_selection")
+
+    # Precedence:
+    # - Explicit row_selection argument (True / dict / RowSelection) wins.
+    # - If row_selection is False (default) and grid_options specifies rowSelection,
+    #   honor grid_options to preserve caller intent.
+    final_row_selection = row_sel_dict
+    if row_selection is False and grid_opt_row_selection is not None:
+        final_row_selection = grid_opt_row_selection
+
     options = GridOptions(
         columnDefs=col_defs,
         defaultColDef=DefaultColDef().to_dict(),
         rowData=row_data_for_grid,
         rowModelType=row_model_type,
-        rowSelection=row_sel_dict,
+        rowSelection=final_row_selection,
         domLayout="normal",
         pagination=pagination,
         paginationPageSize=pagination_page_size,
         cacheBlockSize=cache_block_size,
         enableCellSpan=use_cell_span,
-        **(grid_options or {}),
+        **normalized_grid_options,
     )
 
     context = PyWryGridContext(

pywry/tests/test_grid.py

@@ -10,6 +10,7 @@
 - build_grid_config() main entry point
 - MultiIndex column/row handling
 """
+
 # pylint: disable=too-many-lines
 
 from __future__ import annotations
@@ -741,6 +742,24 @@ def test_grid_options_merge(self):
         assert opts_dict["animateRows"] is True
         assert opts_dict["suppressMenuHide"] is True
 
+    def test_grid_options_row_selection_no_duplicate_error(self):
+        """grid_options.rowSelection is honored without duplicate kwargs error."""
+        extra = {"rowSelection": {"mode": "singleRow", "checkboxes": False}}
+        result = build_grid_config([{"a": 1}], grid_options=extra)
+        opts_dict = result.options.to_dict()
+
+        assert opts_dict["rowSelection"]["mode"] == "singleRow"
+        assert opts_dict["rowSelection"]["checkboxes"] is False
+
+    def test_explicit_row_selection_overrides_grid_options(self):
+        """Explicit row_selection argument overrides grid_options.rowSelection."""
+        extra = {"rowSelection": {"mode": "singleRow", "checkboxes": False}}
+        result = build_grid_config([{"a": 1}], grid_options=extra, row_selection=True)
+        opts_dict = result.options.to_dict()
+
+        assert opts_dict["rowSelection"]["mode"] == "multiRow"
+        assert opts_dict["rowSelection"]["checkboxes"] is True
+
     @pytest.mark.skipif(
         not pytest.importorskip("pandas", reason="pandas required"),
         reason="pandas required",