Add docs build PR check; scale back test matrix on PRs#13
Merged
Conversation
docs.yml now also runs on pull_request (paths: pywry/docs/**, pywry/**/*.py, the workflow itself) so mkdocs build --strict validates every PR before merge. Deploy job is gated to non-PR events and gets its own pages concurrency group; PR concurrency cancels superseded PR runs without ever queueing against a live deploy. test-pywry.yml gains a gen-matrix job that emits one Python per OS on PRs without the full-test label (still 6 OS/arch combos every PR), and the full 12-leg matrix on push, workflow_dispatch, or PRs carrying full-test. fail-fast becomes true on the reduced matrix and false on the full one. pull_request now also fires on labeled/unlabeled so toggling full-test re-triggers the workflow without a fresh push.
deeleeramone
added
documentation
added 3 commits
April 22, 2026 22:40
The 0.3s sleep was occasionally too short under CI load, causing isOpen==True at the assertion. Mirrors the poll loop already used by test_modal_button_click_emits_event in the same file.
gen-matrix now also computes a pytest-targets output by diffing the PR against its base branch. If the only changes are pywry/tests/test_*.py files (and not conftest, constants, source code, or the workflow itself), each platform's pytest invocation runs only those files. Otherwise it runs the full suite as before. The full-test PR label and any non-PR event still pin the full suite. Each step also tolerates pytest exit code 5 (no tests collected) when running scoped, since platform --ignore lists may swallow the targeted file (e.g. test_state_redis_integration.py on Windows).
05-compute-extra.js opened _computeParabolicSAR but its closing brace was leaking into 06-indicator-helpers.js line 1, leaving each file individually unparseable. assets.py concatenates these with '\n' so the runtime output is unchanged; CodeQL's per-file parser now succeeds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs.yml now also runs on pull_request (paths: pywry/docs/, pywry//*.py, the workflow itself) so mkdocs build --strict validates every PR before merge. Deploy job is gated to non-PR events and gets its own pages concurrency group; PR concurrency cancels superseded PR runs without ever queueing against a live deploy.
test-pywry.yml gains a gen-matrix job that emits one Python per OS on PRs without the full-test label (still 6 OS/arch combos every PR), and the full 12-leg matrix on push, workflow_dispatch, or PRs carrying full-test. fail-fast becomes true on the reduced matrix and false on the full one. pull_request now also fires on labeled/unlabeled so toggling full-test re-triggers the workflow without a fresh push.