Merge pull request #50 from Rajendra-R/basescript_metric

#49 modified basescript to remove stats code

Author: Ravipudi Sai Rajendra Prasad

.travis.yml

@@ -6,7 +6,7 @@ install:
   # consider using tox. do we need to install
   - "pip install unittest2"
 script:
-  - "unit2 discover tests"
+  - echo "No tests"
 before_deploy:
   - "wget https://github.com/jgm/pandoc/releases/download/1.19.1/pandoc-1.19.1-1-amd64.deb -O $TRAVIS_BUILD_DIR/pandoc.deb"
   - "sudo dpkg -i $TRAVIS_BUILD_DIR/pandoc.deb"

basescript/basescript.py

@@ -12,8 +12,7 @@
 from threading import Thread
 
 from .log import LevelLoggerFactory, BoundLevelLogger, StdlibStructlogHandler, StderrConsoleRenderer, Stream
-from .stats import Stats
-from .utils import Dummy
+from .utils import Dummy # FIXME: delete this code and use deeputil.Dummy
 
 class BaseScript(object):
     DESC = 'Base script abstraction'
@@ -22,12 +21,6 @@ class BaseScript(object):
     # stdlib to structlog handlers should be configured only once.
     _GLOBAL_LOG_CONFIGURED = False
 
-    # acquires and releases locks for every metric captured
-    THREAD_SAFE_STATS = True
-
-    # periodic interval to dump stats
-    DUMP_STATS_INTERVAL = timedelta(seconds=1)
-
     def __init__(self, args=None):
         # argparse parser obj
         self.parser = argparse.ArgumentParser(description=self.DESC)
@@ -44,13 +37,12 @@ def __init__(self, args=None):
 
         self.hostname = socket.gethostname()
         self.log = self.init_logger()
+        self.stats = Dummy()
 
         args = { n: getattr(self.args, n) for n in vars(self.args) }
         args['func'] = self.args.func.func_name
         self.log.debug("basescript init", **args)
 
-        self.stats = self.init_stats()
-
     def start(self):
         '''
         Starts execution of the script
@@ -247,25 +239,6 @@ def init_logger(self):
         # TODO functionality to change even the level of global stdlib logger.
         return log
 
-    def define_metric_tags(self):
-        """
-        the tags (dictionary {str: str}) returned by this function
-        must be present in every metric that basescript emits.
-        """
-        return { "host": self.hostname, "name": self.name }
-
-    def init_stats(self):
-        basescript_tags = self.define_metric_tags()
-        stats = Stats(self.log, thread_safe=self.THREAD_SAFE_STATS, **basescript_tags)
-
-        self.dump_stats_thread = Thread(
-            target=stats.dump_stats_periodically,
-            kwargs={ 'interval': self.DUMP_STATS_INTERVAL },
-        )
-        self.dump_stats_thread.daemon = True
-        self.dump_stats_thread.start()
-        return stats
-
     def define_subcommands(self, subcommands):
         '''
         Define subcommands (as defined at https://docs.python.org/2/library/argparse.html#sub-commands)