Fix warnings

Author: avishkar58

webapp/src/components/ErrorPage.jsx

@@ -16,7 +16,7 @@ Error Message:
 // Consider logging componentStack and error
 export const ErrorPage = ({ componentStack, error }) => {
   if (errorHandler){
-    var errorMessage= new Object();
+    var errorMessage= {};
     errorMessage.componentStack = componentStack;
     errorMessage.error  = error;
     var jsonString= JSON.stringify(errorMessage);

webapp/src/components/answerValue/AnswerValue.js

@@ -36,7 +36,7 @@ function AnswerValue({answer, question, t}) {
         }
       case FILE:
         return <div>
-          <a target="_blank" href={getDownloadURL(answer.value)}>{t("Uploaded File")}</a>
+          <a target="_blank" rel="noopener noreferrer" href={getDownloadURL(answer.value)}>{t("Uploaded File")}</a>
           <br/>
           <span className="small-text">
             *{t("Note: You may need to change the file name to open the file on certain operating systems")}

webapp/src/components/answerValue/MultiFileValue.js

@@ -7,7 +7,7 @@ function MultiFileValue({value}) {
   return <ul>
     {files.map(v => 
       <li key={"file_" + v.id}>
-        <a target="_blank" href={getDownloadURL(JSON.stringify(v))}>
+        <a target="_blank" rel="noopener noreferrer" href={getDownloadURL(JSON.stringify(v))}>
           {v.name}
         </a>
       </li>)}

webapp/src/components/form/FormDate.js

@@ -7,10 +7,6 @@ import * as moment from 'moment';
 import MarkdownRenderer from "../MarkdownRenderer";
 
 class FormDate extends React.Component {
-  constructor(props) {
-    super(props);
-  }
-
   shouldDisplayError = () => {
     return this.props.showError && this.props.errorText !== "";
 

webapp/src/components/form/MultiFileComponent.js

@@ -33,7 +33,7 @@ import { getDownloadURL } from '../../utils/files';
         let name = this.state.name;
         const rename = value.name;
 
-        if (!this.state.name || this.state.name == "") {
+        if (!this.state.name || this.state.name === "") {
             name = value.name;
         }
 
@@ -94,7 +94,7 @@ import { getDownloadURL } from '../../utils/files';
             </input>)
         }
         else {
-            return (<div className="file-uploaded"><img src={tick} ></img><h6 style={{ marginLeft: "3px" }}>{this.props.value.file.name}</h6></div>)
+            return (<div className="file-uploaded"><img src={tick} alt="" ></img><h6 style={{ marginLeft: "3px" }}>{this.props.value.file.name}</h6></div>)
         }
     }
 
@@ -128,11 +128,11 @@ import { getDownloadURL } from '../../utils/files';
                         ></input>
 
                         <button onClick={this.submit} className={btnSubmit ? "btn-submit show" : "btn-submit"}>{t("Submit")}</button>
-                        <a onClick={this.nameChange} className={isSubmitted || this.props.value.name ? "edit show" : "edit"} data-tip={t("Edit Name")}><i className="fas fa-edit"></i></a>
+                        <button type="button" onClick={this.nameChange} className={isSubmitted || this.props.value.name ? "edit show" : "edit"} data-tip={t("Edit Name")}><i className="fas fa-edit"></i></button>
                         <ReactToolTip type="info" place="top" effect="solid" />
-                        <a onClick={this.del} className={file ? "bin show" : "bin"} data-tip={t("Delete")}><i className="fas fa-trash"></i></a>
+                        <button type="button" onClick={this.del} className={file ? "bin show" : "bin"} data-tip={t("Delete")}><i className="fas fa-trash"></i></button>
                         <ReactToolTip type="info" place="top" effect="solid" />
-                        <a className="view" style={file ? { display: "block" } : { display: "none" }} href={getDownloadURL(JSON.stringify(this.props.value))} target="_blank" data-tip={t("View File")}><i className="far fa-eye"></i></a>
+                        <a className="view" style={file ? { display: "block" } : { display: "none" }} href={getDownloadURL(JSON.stringify(this.props.value))} target="_blank" rel="noopener noreferrer" data-tip={t("View File")}><i className="far fa-eye"></i></a>
                         <ReactToolTip type="info" place="top" effect="solid" />
                     </div>
                     {this.state.error && <p style={{color: "red"}}>{t("Please enter a name")}</p>}

webapp/src/i18n.js

@@ -26,15 +26,15 @@ function i18nInit(organisation) {
         }
       }
 
-      if (found.length == 0) {
+      if (found.length === 0) {
         return undefined;
       }
 
       found = found.map(lang => lang.slice(0, 2));
       const orgLanguageCodes = organisation.languages.map(l => l.code);
       let selectedLanguage = null;
       found.forEach(f => {
-        if (selectedLanguage == null && orgLanguageCodes.includes(f)) {
+        if (selectedLanguage === null && orgLanguageCodes.includes(f)) {
           selectedLanguage = f; 
         }
       })

webapp/src/pages/ResponsePage/ResponsePage.js

@@ -437,10 +437,8 @@ class ResponsePage extends Component {
                 return <div key={choices}>{choices}</div>
             }
             // other
-            else {
-                return <div key={headline}><p className="answer">{a.value}</p></div>
-            };
-        };
+            return <div key={headline}><p className="answer">{a.value}</p></div>
+        }
     };
 
     // render Delete Modal

webapp/src/pages/eventConfig/components/EventConfigComponent.js

@@ -138,7 +138,7 @@ class EventConfigComponent extends Component {
 
   onClickUpdate = () => {
     const errors = this.validateEventDetails();
-    if (errors.length == 0) { //PUT
+    if (errors.length === 0) { //PUT
       const event_with_times = this.addTimeToDates(this.state.updatedEvent);
       eventService.update(event_with_times).then(result => {
       if (result.error) {
@@ -221,7 +221,7 @@ class EventConfigComponent extends Component {
     if (this.state.updatedEvent.email_from.trim().length === 0) {
       errors.push(this.props.t("Organisation email is required"));
     }
-    if (!/^\w+([\.-]?\w+)*@\w+([\.-]?\w+)*(\.\w{2,3})+$/.test(this.state.updatedEvent.email_from)) {
+    if (!/^\w+([.-]?\w+)*@\w+([.-]?\w+)*(\.\w{2,3})+$/.test(this.state.updatedEvent.email_from)) {
       errors.push(this.props.t("Organisation email is invalid"));
     }
     if (this.state.updatedEvent.url.trim().length === 0) {

webapp/src/pages/formEditor/components/DependencyEditor.js

@@ -43,7 +43,7 @@ const DependencyEditor = ({
   const [isInitialized, setIsInitialized] = useState(false);
   const [showJsonPreview, setShowJsonPreview] = useState(false);
   const [linkedFormQuestions, setLinkedFormQuestions] = useState([]);
-  const [loadingLinkedQuestions, setLoadingLinkedQuestions] = useState(false);
+  const [, setLoadingLinkedQuestions] = useState(false);
 
   useEffect(() => {
     if (!isInitialized) {

webapp/src/pages/invoices/components/InvoiceAdminListComponent.js

@@ -1,6 +1,5 @@
 import React, { Component } from "react";
 import { withRouter } from "react-router";
-import { NavLink } from "react-router-dom";
 import Loading from "../../../components/Loading";
 import { invoiceService } from "../../../services/invoices/invoices.service";
 import { Trans, withTranslation } from 'react-i18next'