Fix: Chart update failed in case missing gitops repo, just added logs to make (devtron-labs#1600)

* there no bug inside the code for this issue, just added logs to make debuging easy

* review change

Author: vikramdevtron

pkg/appStore/deployment/fullMode/AppStoreDeploymentFullModeService.go

@@ -59,7 +59,7 @@ type AppStoreDeploymentFullModeService interface {
 	SyncACD(acdAppName string, ctx context.Context)
 	UpdateValuesYaml(installAppVersionRequest *appStoreBean.InstallAppVersionDTO) (*appStoreBean.InstallAppVersionDTO, error)
 	UpdateRequirementYaml(installAppVersionRequest *appStoreBean.InstallAppVersionDTO, appStoreAppVersion *appStoreDiscoverRepository.AppStoreApplicationVersion) error
-	GetGitOpsRepoName(installAppVersionRequest *appStoreBean.InstallAppVersionDTO) string
+	GetGitOpsRepoName(installAppVersionRequest *appStoreBean.InstallAppVersionDTO) (string, error)
 }
 
 type AppStoreDeploymentFullModeServiceImpl struct {
@@ -307,30 +307,33 @@ func (impl AppStoreDeploymentFullModeServiceImpl) createInArgo(chartGitAttribute
 	return nil
 }
 
-func (impl AppStoreDeploymentFullModeServiceImpl) GetGitOpsRepoName(installAppVersionRequest *appStoreBean.InstallAppVersionDTO) string {
+func (impl AppStoreDeploymentFullModeServiceImpl) GetGitOpsRepoName(installAppVersionRequest *appStoreBean.InstallAppVersionDTO) (string, error) {
+	gitOpsRepoName := ""
 	ctx, err := impl.tokenCache.BuildACDSynchContext()
 	if err != nil {
-		impl.logger.Errorw("error in creating acd synch context", "err", err)
-		return ""
+		impl.logger.Errorw("error in creating acd sync context", "err", err)
+		return "", err
 	}
 	acdAppName := fmt.Sprintf("%s-%s", installAppVersionRequest.AppName, installAppVersionRequest.EnvironmentName)
-	gitOpsRepoName := ""
 	application, err := impl.acdClient.Get(ctx, &application.ApplicationQuery{Name: &acdAppName})
 	if err != nil {
-		impl.logger.Errorw("no argo app exists", "app", acdAppName)
-		return ""
+		impl.logger.Errorw("no argo app exists", "acdAppName", acdAppName, "err", err)
+		return "", err
 	}
 	if application != nil {
 		gitOpsRepoUrl := application.Spec.Source.RepoURL
 		gitOpsRepoName = impl.chartTemplateService.GetGitOpsRepoNameFromUrl(gitOpsRepoUrl)
 	}
-	return gitOpsRepoName
+	return gitOpsRepoName, nil
 }
 
 func (impl AppStoreDeploymentFullModeServiceImpl) UpdateValuesYaml(installAppVersionRequest *appStoreBean.InstallAppVersionDTO) (*appStoreBean.InstallAppVersionDTO, error) {
 	acdAppName := fmt.Sprintf("%s-%s", installAppVersionRequest.AppName, installAppVersionRequest.EnvironmentName)
 	if len(installAppVersionRequest.GitOpsRepoName) == 0 {
-		gitOpsRepoName := impl.GetGitOpsRepoName(installAppVersionRequest)
+		gitOpsRepoName, err := impl.GetGitOpsRepoName(installAppVersionRequest)
+		if err != nil {
+			return installAppVersionRequest, err
+		}
 		installAppVersionRequest.GitOpsRepoName = gitOpsRepoName
 	}
 	valuesOverrideByte, err := yaml.YAMLToJSON([]byte(installAppVersionRequest.ValuesOverrideYaml))

pkg/appStore/deployment/service/InstalledAppService.go

@@ -184,7 +184,10 @@ func (impl InstalledAppServiceImpl) UpdateInstalledApp(ctx context.Context, inst
 	argocdAppName := installedApp.App.AppName + "-" + installedApp.Environment.Name
 	gitOpsRepoName := installedApp.GitOpsRepoName
 	if len(gitOpsRepoName) == 0 {
-		gitOpsRepoName = impl.appStoreDeploymentFullModeService.GetGitOpsRepoName(installAppVersionRequest)
+		gitOpsRepoName, err = impl.appStoreDeploymentFullModeService.GetGitOpsRepoName(installAppVersionRequest)
+		if err != nil {
+			return nil, err
+		}
 	}
 	installAppVersionRequest.GitOpsRepoName = gitOpsRepoName
 	var installedAppVersion *repository2.InstalledAppVersions

pkg/util/TokenCache.go

@@ -46,6 +46,7 @@ func NewTokenCache(logger *zap.SugaredLogger, aCDAuthConfig *ACDAuthConfig, user
 }
 func (impl *TokenCache) BuildACDSynchContext() (acdContext context.Context, err error) {
 	token, found := impl.cache.Get("token")
+	impl.logger.Debugw("building acd context", "token", token, "found", found)
 	if !found {
 		token, err := impl.userAuthService.HandleLogin(impl.aCDAuthConfig.ACDUsername, impl.aCDAuthConfig.ACDPassword)
 		if err != nil {