Skip to content

Fixed miri tests#645

Merged
marvin-hansen merged 14 commits into
deepcausality-rs:mainfrom
marvin-hansen:main
Jun 22, 2026
Merged

Fixed miri tests#645
marvin-hansen merged 14 commits into
deepcausality-rs:mainfrom
marvin-hansen:main

Conversation

@marvin-hansen

@marvin-hansen marvin-hansen commented Jun 22, 2026

Copy link
Copy Markdown
Member

Describe your changes

Fixed miri tests

Issue ticket number and link

#643

Code checklist before requesting a review

  • I have signed the DCO?
  • All tests are passing when running make test?
  • No errors or security vulnerabilities are reported by make check?

For details on make, please see BUILD.md

Note: The CI runs all of the above and fixing things before they hit CI speeds
up the review and merge process. Thank you.


Summary by cubic

Fixes Miri test failures by gating ULP‑sensitive float and stochastic tests under miri and adding ignores for unstable cases. Normal CI still runs the full suite. Addresses #643.

  • Bug Fixes
    • deep_causality_num: gate algebra f32/f64, float_32/64, and double_erf/double_transcendental with #[cfg(not(miri))]; remove redundant per‑test ignores.
    • deep_causality_rand: gate inverse CDF, Sobol, and uniform tests; add #[cfg_attr(miri, ignore)] to StandardNormal mean/std; minor formatting/linting.
    • deep_causality_uncertain: gate QMC and sequential sampler, plus uncertain_* and uncertain_maybe_* modules; drop per‑test ignores.

Written for commit aee75a8. Summary will update on new commits.

Review in cubic

@marvin-hansen marvin-hansen self-assigned this Jun 22, 2026
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 6 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread deep_causality_num/tests/float_double/mod.rs Outdated
Comment thread deep_causality_num/tests/algebra/mod.rs
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
@marvin-hansen marvin-hansen merged commit 8c5fa51 into deepcausality-rs:main Jun 22, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant