feat: polish metadb index definition

Author: ZhengYa-0110

server/controller/db/metadb/migrator/schema/const.go

@@ -20,5 +20,5 @@ const (
 	RAW_SQL_ROOT_DIR = "/etc/metadb/schema/rawsql"
 
 	DB_VERSION_TABLE    = "db_version"
-	DB_VERSION_EXPECTED = "7.1.0.38"
+	DB_VERSION_EXPECTED = "7.1.0.39"
 )

server/controller/db/metadb/migrator/schema/rawsql/mysql/ddl_create_table.sql

@@ -232,7 +232,8 @@ CREATE TABLE IF NOT EXISTS vtap (
     team_id                 INTEGER,
     expected_revision       TEXT,
     upgrade_package         TEXT,
-    lcuuid                  CHAR(64)
+    lcuuid                  CHAR(64),
+    INDEX lcuuid_index(lcuuid)
 ) ENGINE=InnoDB AUTO_INCREMENT=1 DEFAULT CHARSET=utf8;
 TRUNCATE TABLE vtap;
 
@@ -385,6 +386,7 @@ CREATE TABLE IF NOT EXISTS domain (
     synced_at           DATETIME DEFAULT NULL,
     created_at          DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
     updated_at          DATETIME NOT NULL ON UPDATE CURRENT_TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
+    INDEX team_id_index(team_id),
     UNIQUE INDEX lcuuid_index(lcuuid)
 )ENGINE=innodb DEFAULT CHARSET=utf8 AUTO_INCREMENT=1;
 TRUNCATE TABLE domain;
@@ -408,6 +410,7 @@ CREATE TABLE IF NOT EXISTS sub_domain (
     created_at          DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
     updated_at          DATETIME NOT NULL ON UPDATE CURRENT_TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
     deleted_at          DATETIME DEFAULT NULL,
+    INDEX team_id_index(team_id),
     UNIQUE INDEX lcuuid_index(lcuuid)
 )ENGINE=innodb DEFAULT CHARSET=utf8 AUTO_INCREMENT=1;
 TRUNCATE TABLE sub_domain;
@@ -488,8 +491,7 @@ CREATE TABLE IF NOT EXISTS vm (
     INDEX launch_server_index(launch_server),
     INDEX epc_id_index(epc_id),
     INDEX az_index(az),
-    INDEX region_index(region),
-    INDEX id_index(`id`)
+    INDEX region_index(region)
 )ENGINE=innodb AUTO_INCREMENT=1 DEFAULT CHARSET=utf8;
 TRUNCATE TABLE vm;
 
@@ -594,7 +596,8 @@ CREATE TABLE IF NOT EXISTS vl2_net (
     lcuuid              CHAR(64) DEFAULT '',
     created_at          DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
     updated_at          DATETIME NOT NULL ON UPDATE CURRENT_TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
-    PRIMARY KEY (id)
+    PRIMARY KEY (id),
+    INDEX vl2id_index(vl2id)
 ) ENGINE=innodb DEFAULT CHARSET=utf8 AUTO_INCREMENT=1;
 TRUNCATE TABLE vl2_net;
 
@@ -672,7 +675,9 @@ CREATE TABLE IF NOT EXISTS vinterface (
     created_at          DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
     updated_at          DATETIME NOT NULL ON UPDATE CURRENT_TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
     INDEX epc_id_index(epc_id),
-    INDEX mac_index(mac)
+    INDEX mac_index(mac),
+    INDEX devicetype_index(devicetype),
+    INDEX lcuuid_index(lcuuid)
 )ENGINE=innodb AUTO_INCREMENT=1 DEFAULT CHARSET=utf8;
 TRUNCATE TABLE vinterface;
 
@@ -693,7 +698,8 @@ CREATE TABLE IF NOT EXISTS vinterface_ip (
     created_at          DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
     updated_at          DATETIME NOT NULL ON UPDATE CURRENT_TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
     INDEX ip_index(`ip`),
-    INDEX vifid_index(`vifid`)
+    INDEX vifid_index(`vifid`),
+    INDEX lcuuid_index(lcuuid)
 ) ENGINE=innodb DEFAULT CHARSET=utf8 AUTO_INCREMENT=1;
 TRUNCATE TABLE vinterface_ip;
 
@@ -715,7 +721,8 @@ CREATE TABLE IF NOT EXISTS ip_resource (
     created_at          DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
     updated_at          DATETIME NOT NULL ON UPDATE CURRENT_TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
     INDEX ip_index(`ip`),
-    INDEX vifid_index(`vifid`)
+    INDEX vifid_index(`vifid`),
+    INDEX lcuuid_index(lcuuid)
 )ENGINE=innodb DEFAULT CHARSET=utf8 AUTO_INCREMENT=1;
 TRUNCATE TABLE ip_resource;
 
@@ -985,7 +992,8 @@ CREATE TABLE IF NOT EXISTS vm_pod_node_connection (
     sub_domain          CHAR(64) DEFAULT '',
     lcuuid              CHAR(64) DEFAULT '',
     created_at          DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
-    updated_at          DATETIME NOT NULL ON UPDATE CURRENT_TIMESTAMP DEFAULT CURRENT_TIMESTAMP
+    updated_at          DATETIME NOT NULL ON UPDATE CURRENT_TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
+    INDEX pod_node_id_index(pod_node_id)
 ) ENGINE=innodb AUTO_INCREMENT=1 DEFAULT CHARSET=utf8;
 TRUNCATE TABLE vm_pod_node_connection;
 
@@ -1101,7 +1109,8 @@ CREATE TABLE IF NOT EXISTS pod_service_port (
     lcuuid              CHAR(64),
     created_at          DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,
     updated_at          DATETIME NOT NULL ON UPDATE CURRENT_TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
-    INDEX pod_service_id_index(pod_service_id)
+    INDEX pod_service_id_index(pod_service_id),
+    INDEX lcuuid_index(lcuuid)
 ) ENGINE=innodb AUTO_INCREMENT=1 DEFAULT CHARSET=utf8;
 TRUNCATE TABLE pod_service_port;
 
@@ -1130,7 +1139,8 @@ CREATE TABLE IF NOT EXISTS pod_group (
     deleted_at          DATETIME DEFAULT NULL,
     INDEX pod_namespace_id_index(pod_namespace_id),
     INDEX pod_cluster_id_index(pod_cluster_id),
-    INDEX lcuuid_index(lcuuid)
+    INDEX lcuuid_index(lcuuid),
+    INDEX deleted_at_index(deleted_at)
 ) ENGINE=innodb AUTO_INCREMENT=1 DEFAULT CHARSET=utf8;
 TRUNCATE TABLE pod_group;
 
@@ -1168,7 +1178,8 @@ CREATE TABLE IF NOT EXISTS pod_rs (
     updated_at          DATETIME NOT NULL ON UPDATE CURRENT_TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
     deleted_at          DATETIME DEFAULT NULL,
     INDEX pod_group_id_index(pod_group_id),
-    INDEX pod_namespace_id_index(pod_namespace_id)
+    INDEX pod_namespace_id_index(pod_namespace_id),
+    INDEX lcuuid_index(lcuuid)
 ) ENGINE=innodb AUTO_INCREMENT=1 DEFAULT CHARSET=utf8;
 TRUNCATE TABLE pod_rs;
 
@@ -1207,7 +1218,10 @@ CREATE TABLE IF NOT EXISTS pod (
     INDEX az_index(az),
     INDEX region_index(region),
     INDEX domain_index(domain),
-    INDEX lcuuid_index(lcuuid)
+    INDEX lcuuid_index(lcuuid),
+    INDEX pod_ns_created_at_index(pod_namespace_id, created_at),
+    INDEX pod_cluster_created_at_index(pod_cluster_id, created_at),
+    INDEX deleted_at_index(deleted_at)
 ) ENGINE=innodb AUTO_INCREMENT=1 DEFAULT CHARSET=utf8;
 TRUNCATE TABLE pod;
 
@@ -1274,7 +1288,8 @@ CREATE TABLE IF NOT EXISTS process (
     deleted_at          DATETIME DEFAULT NULL,
     INDEX domain_sub_domain_gid_updated_at_index(domain, sub_domain, gid, updated_at DESC),
     INDEX deleted_at_index(deleted_at),
-    INDEX lcuuid_index(lcuuid)
+    INDEX lcuuid_index(lcuuid),
+    INDEX vtap_id_index(vtap_id)
 ) ENGINE=innodb DEFAULT CHARSET=utf8 AUTO_INCREMENT=1;
 TRUNCATE TABLE process;
 
@@ -1743,7 +1758,8 @@ CREATE TABLE IF NOT EXISTS ch_os_app_tag (
     `sub_domain_id`    INTEGER,
     `updated_at`       TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,
     PRIMARY KEY (`id`, `key`),
-    INDEX updated_at_index(`updated_at`)
+    INDEX updated_at_index(`updated_at`),
+    INDEX domain_sub_domain_id_updated_at_index(domain_id, sub_domain_id, id, updated_at ASC)
 )ENGINE=innodb DEFAULT CHARSET=utf8;
 TRUNCATE TABLE ch_os_app_tag;
 

server/controller/db/metadb/migrator/schema/rawsql/mysql/issu/7.1.0.39.sql

@@ -0,0 +1,134 @@
+DROP PROCEDURE IF EXISTS AddIndexIfNotExists;
+
+CREATE PROCEDURE AddIndexIfNotExists(
+    IN tableName VARCHAR(255),
+    IN indexName VARCHAR(255),
+    IN indexCol  VARCHAR(255)
+)
+BEGIN
+    DECLARE index_count INT;
+
+    SELECT COUNT(*)
+    INTO index_count
+    FROM information_schema.statistics
+    WHERE table_schema = DATABASE()
+      AND table_name   = tableName
+      AND column_name  = indexCol;
+
+    IF index_count = 0 THEN
+        SET @sql = CONCAT('ALTER TABLE ', tableName, ' ADD INDEX ', indexName, ' (', indexCol, ') USING BTREE');
+        PREPARE stmt FROM @sql;
+        EXECUTE stmt;
+        DEALLOCATE PREPARE stmt;
+    END IF;
+END;
+
+DROP PROCEDURE IF EXISTS AddNamedIndexIfNotExists;
+
+-- AddNamedIndexIfNotExists checks by index name (required for composite indexes where
+-- the leading column may already have a separate single-column index).
+CREATE PROCEDURE AddNamedIndexIfNotExists(
+    IN tableName VARCHAR(255),
+    IN indexName VARCHAR(255),
+    IN indexDef  VARCHAR(1024)
+)
+BEGIN
+    DECLARE index_count INT;
+
+    SELECT COUNT(*)
+    INTO index_count
+    FROM information_schema.statistics
+    WHERE table_schema = DATABASE()
+      AND table_name   = tableName
+      AND index_name   = indexName;
+
+    IF index_count = 0 THEN
+        SET @sql = CONCAT('ALTER TABLE ', tableName, ' ADD INDEX ', indexName, ' ', indexDef);
+        PREPARE stmt FROM @sql;
+        EXECUTE stmt;
+        DEALLOCATE PREPARE stmt;
+    END IF;
+END;
+
+DROP PROCEDURE IF EXISTS DeleteIndexIfExists;
+
+CREATE PROCEDURE DeleteIndexIfExists(
+    IN tableName VARCHAR(255),
+    IN indexName VARCHAR(255)
+)
+BEGIN
+    DECLARE index_count INT;
+
+    SELECT COUNT(*)
+    INTO index_count
+    FROM information_schema.statistics
+    WHERE table_schema = DATABASE()
+      AND table_name   = tableName
+      AND index_name   = indexName;
+
+    IF index_count > 0 THEN
+        SET @sql = CONCAT('ALTER TABLE ', tableName, ' DROP INDEX ', indexName);
+        PREPARE stmt FROM @sql;
+        EXECUTE stmt;
+        DEALLOCATE PREPARE stmt;
+    END IF;
+END;
+
+-- P0: Remove redundant index on vm(id) — id is already the PRIMARY KEY in InnoDB
+CALL DeleteIndexIfExists('vm', 'id_index');
+
+-- P0: vinterface — 10w-50w rows; devicetype_index speeds up pod/vm data-build subqueries
+--     (WHERE devicetype = N); lcuuid_index speeds up recorder per-resource Update/Delete
+CALL AddIndexIfNotExists('vinterface', 'devicetype_index', 'devicetype');
+CALL AddIndexIfNotExists('vinterface', 'lcuuid_index', 'lcuuid');
+
+-- P0: vinterface_ip — 10w-50w rows; recorder per-resource Update/Delete by lcuuid
+CALL AddIndexIfNotExists('vinterface_ip', 'lcuuid_index', 'lcuuid');
+
+-- P0: ip_resource — 5w-50w rows; recorder per-resource Update/Delete by lcuuid
+CALL AddIndexIfNotExists('ip_resource', 'lcuuid_index', 'lcuuid');
+
+-- P1: vtap — multi-module (monitor/genesis/trisolaris) high-frequency lcuuid operations
+CALL AddIndexIfNotExists('vtap', 'lcuuid_index', 'lcuuid');
+
+-- P1: pod_rs — recorder CRUD by lcuuid
+CALL AddIndexIfNotExists('pod_rs', 'lcuuid_index', 'lcuuid');
+
+-- P1: pod_service_port — 1w-1.5w rows; recorder CRUD by lcuuid
+CALL AddIndexIfNotExists('pod_service_port', 'lcuuid_index', 'lcuuid');
+
+-- P1: vl2_net(subnet) — cleaner cascade delete and subnet queries by vl2id
+CALL AddIndexIfNotExists('vl2_net', 'vl2id_index', 'vl2id');
+
+-- P1: vm_pod_node_connection — cleaner cascade delete by pod_node_id
+CALL AddIndexIfNotExists('vm_pod_node_connection', 'pod_node_id_index', 'pod_node_id');
+
+-- P1: pod — composite indexes for HTTP API paginated + ORDER BY created_at queries
+--     pod_namespace_id and pod_cluster_id already have single-column indexes; these
+--     composites add ORDER BY support without filesort (use AddNamedIndexIfNotExists
+--     since the leading column already has a separate index)
+CALL AddNamedIndexIfNotExists('pod', 'pod_ns_created_at_index',      '(pod_namespace_id, created_at)');
+CALL AddNamedIndexIfNotExists('pod', 'pod_cluster_created_at_index', '(pod_cluster_id,   created_at)');
+
+-- P1: process — large table (10w-50w rows); vtap_id_index enables DB-side filtering
+--     once the application layer is refactored to push vtap_id filters to SQL
+CALL AddIndexIfNotExists('process', 'vtap_id_index', 'vtap_id');
+
+-- P2: domain / sub_domain — team_id_index for FPermit non-admin per-request WHERE team_id IN (?)
+CALL AddIndexIfNotExists('domain',     'team_id_index', 'team_id');
+CALL AddIndexIfNotExists('sub_domain', 'team_id_index', 'team_id');
+
+-- P2: pod / pod_group — deleted_at_index for cleaner WHERE deleted_at < ? (soft-delete cleanup)
+CALL AddIndexIfNotExists('pod',       'deleted_at_index', 'deleted_at');
+CALL AddIndexIfNotExists('pod_group', 'deleted_at_index', 'deleted_at');
+
+-- P2: ch_os_app_tag — 10w+ rows (PK=(id,key)); composite index matches tagrecorder healer
+--     WHERE domain_id = ? AND sub_domain_id = ? and ClickHouse dict ORDER BY updated_at
+CALL AddNamedIndexIfNotExists('ch_os_app_tag', 'domain_sub_domain_id_updated_at_index',
+    '(domain_id, sub_domain_id, id, updated_at ASC)');
+
+DROP PROCEDURE IF EXISTS AddIndexIfNotExists;
+DROP PROCEDURE IF EXISTS AddNamedIndexIfNotExists;
+DROP PROCEDURE IF EXISTS DeleteIndexIfExists;
+
+UPDATE db_version SET version='7.1.0.39';