test: guard ai agent exec verifier constraints

Author: kylewanginchina

agent/src/ebpf/test/test_ai_agent_source_contracts.py

@@ -299,9 +299,14 @@ def read_source(path: Path) -> str:
         path_facts_start != -1 and path_facts_end != -1,
         "AI Agent exec BPF must keep path fact helper recognizable",
     )
+    path_facts_text = exec_common_text[path_facts_start:path_facts_end]
     require(
-        "#pragma unroll" not in exec_common_text[path_facts_start:path_facts_end],
-        "AI Agent exec path fact collection must use a bounded loop, not a 256-byte unroll that bloats verifier processing",
+        re.search(r"#define\s+AI_AGENT_EXEC_PATTERN_SCAN_LEN\s+64", exec_common_text)
+        and "#ifdef AI_AGENT_EXEC_UNROLL_PATH_FACTS" in path_facts_text
+        and "#pragma unroll" in path_facts_text
+        and "for (__u32 i = 0; i < AI_AGENT_EXEC_PATTERN_SCAN_LEN; i++)" in path_facts_text
+        and "if (!ended || len == 0)" in path_facts_text,
+        "AI Agent exec path fact collection must scan a verifier-friendly 64-byte prefix and only unroll in small enforcement objects",
     )
     require(
         "AI_AGENT_EXEC_CMDLINE_PREFIX_LEN" in exec_common_text
@@ -332,6 +337,10 @@ def read_source(path: Path) -> str:
         and "argv_pattern_hash" not in lsm_body,
         "AI Agent exec LSM hook must ignore argv/cmdline-qualified rules to avoid path-only false positives",
     )
+    require(
+        "#define AI_AGENT_EXEC_UNROLL_PATH_FACTS" in exec_enforce_text,
+        "AI Agent exec LSM hook must unroll the 64-byte path fact helper to avoid bounded-loop verifier state explosion",
+    )
     require(
         "pattern_hash" in exec_common_text
         and "ai_agent_hash_exec_path" in exec_common_text,
@@ -389,11 +398,18 @@ def read_source(path: Path) -> str:
     )
     require(
         re.search(r"#define\s+AI_AGENT_EXEC_OVERRIDE_ARG_LEN\s+64", exec_override_text)
+        and re.search(r"#define\s+AI_AGENT_EXEC_CMDLINE_LEN\s+64", exec_override_text)
+        and re.search(r"#define\s+AI_AGENT_EXEC_CMDLINE_MAX_ARGS\s+4", exec_override_text)
+        and re.search(r"#define\s+AI_AGENT_EXEC_CMDLINE_ARG_LEN\s+32", exec_override_text)
         and "ai_agent_exec_override_read_argv_index" in exec_override_text
         and "rule->argv_index" in exec_override_text
         and "rule->argv_op != AI_AGENT_EXEC_ARGV_OP_EXACT" in exec_override_text
         and "ai_agent_exec_override_arg_matches" in exec_override_text,
-        "AI Agent exec override must read only the configured argv index",
+        "AI Agent exec override must read only bounded argv/cmdline data that old verifiers can load",
+    )
+    require(
+        "#define AI_AGENT_EXEC_UNROLL_PATH_FACTS" in exec_override_text,
+        "AI Agent exec override must unroll the 64-byte path fact helper to avoid bounded-loop verifier state explosion",
     )
     require(
         "ai_agent_exec_override_read_syscall_arg" in exec_override_text
@@ -436,8 +452,10 @@ def read_source(path: Path) -> str:
         cmdline_prefix_match_start:cmdline_prefix_match_end
     ]
     require(
-        "#pragma unroll" not in cmdline_prefix_match_text,
-        "AI Agent exec override must not unroll 32-word cmdline prefix matching; it makes verifier state exceed the 1M processed-insn limit",
+        re.search(r"#define\s+AI_AGENT_EXEC_CMDLINE_PREFIX_MATCH_WORDS\s+8", exec_common_text)
+        and "#pragma clang loop unroll(disable)" in cmdline_prefix_match_text
+        and "i < AI_AGENT_EXEC_CMDLINE_PREFIX_MATCH_WORDS" in cmdline_prefix_match_text,
+        "AI Agent exec override must limit cmdline prefix matching to 8 words and prevent clang from auto-unrolling the comparison loop",
     )
     append_arg_start = exec_override_text.find(
         "ai_agent_exec_override_cmdline_append_arg("
@@ -461,9 +479,10 @@ def read_source(path: Path) -> str:
     cmdline_append_arg_text = exec_override_text[append_arg_start:read_argv_ptr_start]
     build_cmdline_text = exec_override_text[build_cmdline_start:read_argv_index_start]
     require(
-        "#pragma unroll" not in cmdline_append_arg_text
-        and "#pragma unroll" not in build_cmdline_text,
-        "AI Agent exec override must not unroll argv cmdline construction; it makes kprobe override programs too large",
+        "#pragma unroll" in cmdline_append_arg_text
+        and "#pragma unroll" not in build_cmdline_text
+        and "#pragma clang loop" not in build_cmdline_text,
+        "AI Agent exec override must unroll only the 32-byte arg copy loop and keep argv iteration bounded",
     )
     require(
         "ai_agent_exec_override_arg_reset" in exec_override_text