Skip to content

fix: return remote exec errors for unsupported types#11584

Merged
kylewanginchina merged 1 commit intomainfrom
temp-codex-remote-exec-unsupported-20260403
Apr 7, 2026
Merged

fix: return remote exec errors for unsupported types#11584
kylewanginchina merged 1 commit intomainfrom
temp-codex-remote-exec-unsupported-20260403

Conversation

@rvql
Copy link
Copy Markdown
Contributor

@rvql rvql commented Apr 4, 2026

This PR is for:

  • Agent

@rvql rvql requested a review from kylewanginchina April 4, 2026 00:28
@rvql
Copy link
Copy Markdown
Contributor Author

rvql commented Apr 4, 2026

@claude review this code

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Apr 4, 2026

Claude finished @rvql's task in 5m 50s —— View job


Review complete

  • Update the PR comment with a review checklist
  • Inspect the PR diff and relevant files
  • Analyze the change for correctness and regressions
  • Post the review feedback to the PR comment

Result

I did not find any blocking issues in this PR.

The main behavior change in @agent/src/rpc/remote_exec.rs:894-931 looks correct: unsupported exec_type values now return an explicit RemoteExecResponse with errmsg instead of being silently ignored. That also correctly covers the non-enterprise case where DRY_REPLAY_PCAP is defined in the proto but not handled by this build.

The added tests at @agent/src/rpc/remote_exec.rs:1455-1499 are a good regression check for both cases:

  • unknown raw enum values (99)
  • known-but-unsupported enum variants (DryReplayPcap without the enterprise feature)

Notes

This was a static review. I wasn't able to run git diff origin/main...HEAD or Rust tests in this run because shell access was not available.

@rvql rvql force-pushed the temp-codex-remote-exec-unsupported-20260403 branch from 0fa1ead to e2b6bc5 Compare April 4, 2026 00:30
@kylewanginchina kylewanginchina merged commit cb14528 into main Apr 7, 2026
10 checks passed
@kylewanginchina kylewanginchina deleted the temp-codex-remote-exec-unsupported-20260403 branch April 7, 2026 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants