fix(querier): force layered aggregation for boolean COUNTER metrics#11799
Merged
Conversation
For COUNTER metrics with boolean DBField (containing if(..., 1, 0)), aggregation functions other than SUM/AVG produce meaningless row-level results in UNLAY mode (e.g. MAX is always 1, AVG is 0/1 ratio). Force them to LAYERED mode: inner SUM aggregates by datasource_interval, outer applies the actual aggregation function on per-window counts. This gives meaningful semantics such as MAX(SUM(...)) for peak window rate. Co-Authored-By: Claude <noreply@anthropic.com>
JinzhouChen-xmu
force-pushed
the
fix_boolean_counter
branch
from
777f0f8 to
97e1ae0
Compare
zhens0704
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For COUNTER metrics with boolean DBField (containing if(..., 1, 0)), aggregation functions other than SUM/AVG produce meaningless row-level results in UNLAY mode (e.g. MAX is always 1, AVG is 0/1 ratio).
Force them to LAYERED mode: inner SUM aggregates by datasource_interval, outer applies the actual aggregation function on per-window counts. This gives meaningful semantics such as MAX(SUM(...)) for peak window rate.
This PR is for:
Server