Add @internal namespace for auto-assigned node IDs. Fixes #31 (#32)

* Add @internal namespace for auto-assigned node IDs. Fixes #31

* Add test for ID collisions

Author: brollb

src/common/JSONImporter.js

@@ -13,6 +13,7 @@ define([
         constructor(core, rootNode) {
             this.core = core;
             this.rootNode = rootNode;
+            this._nodeIDCounter = 1;
         }
 
         async _metaDictToGuids(meta_dict){
@@ -283,7 +284,7 @@ define([
 
         async createNode(parent, state={}, base) {
             if (!state.id) {
-                state.id = `@id:${Date.now() + Math.floor(100*Math.random())}`;
+                state.id = `@internal:${this._nodeIDCounter++}`;
             }
             const idString = state.id;
             const fco = await this.core.loadByPath(this.rootNode, '/1');
@@ -776,7 +777,7 @@ define([
                     .find(child => core.getAttribute(child, attr) === value);
             }
 
-            if (this.tag === '@id') {
+            if (this.tag === '@id' || this.tag === '@internal') {
                 return null;
             }
 
@@ -877,7 +878,7 @@ define([
 
         isAbsolute() {
             return this.tag === '@meta' || this.tag === '@path' ||
-                this.tag === '@id' || this.tag === '@guid';
+                this.tag === '@id' || this.tag === '@guid' || this.tag === '@internal';
         }
     }
 

test/common/JSONImporter.spec.js

@@ -1154,6 +1154,17 @@ describe('JSONImporter', function () {
             );
         });
 
+        it('should not have collisions for auto-gen IDs', async function() {
+            const fco = await core.loadByPath(root, '/1');
+            const container = core.createNode({base: fco, parent: root});
+            const childCount = 1000;
+            const schema = {
+                children: [...new Array(childCount)].map(() => ({})),
+            };
+            await importer.apply(container, schema);
+            assert.equal(childCount, core.getChildrenPaths(container).length);
+        });
+
         describe('prepare', function() {
             it('should add @meta node to META', async function() {
                 const selector = new Importer.NodeSelector('@meta:TestMeta');