feat: Use feature flag to allow rustls-no-provider with reqwest#162
Open
SanchayanMaity wants to merge 1 commit into
Open
feat: Use feature flag to allow rustls-no-provider with reqwest#162SanchayanMaity wants to merge 1 commit into
SanchayanMaity wants to merge 1 commit into
Conversation
This allows applications or other users of the crate to not bring aws-lc-rs as a dependency due to cargo feature unification and let a user of the crate install a crypto provider manually for use by reqwest. See https://docs.rs/rustls/latest/rustls/#cryptography-providers for details. When opting into reqwest/rustls-no-provider, application must install a crypto provider. For example, rustls::crypto::ring::default_provider().install_default().
Author
|
For some more context on this change, We use the deepgram SDK in GStreamer for transcribing. We have avoided pulling in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows applications or other users of the crate to not bring aws-lc-rs as a dependency due to cargo feature unification and let a user of the crate install a crypto provider manually for use by reqwest.
See https://docs.rs/rustls/latest/rustls/#cryptography-providers for details.
When opting into reqwest/rustls-no-provider, application must install a crypto provider. For example, rustls::crypto::ring::default_provider().install_default().
Proposed changes
Types of changes
Checklist
Further comments