fix: DH-22416: Patch out GWT Logging's requirement of checking location#8017
Open
niloc132 wants to merge 1 commit into
Open
fix: DH-22416: Patch out GWT Logging's requirement of checking location#8017niloc132 wants to merge 1 commit into
niloc132 wants to merge 1 commit into
Conversation
niloc132
added
NoDocumentationNeeded
NoReleaseNotesNeeded
Contributor
No docs changes detected for bf848ae |
bmingles
reviewed
May 11, 2026
| import com.google.gwt.core.client.EntryPoint; | ||
| import com.google.gwt.core.client.GWT; | ||
| import com.google.gwt.core.client.GWT.UncaughtExceptionHandler; | ||
| import com.google.gwt.user.client.Window.Location; |
Contributor
There was a problem hiding this comment.
Copilot noticed import Window.Location is imported but doesn't seem to be used. Is this just a GWT nuance, or should this be removed?
Member
Author
There was a problem hiding this comment.
No, this is correct, it should be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.