Skip to content

fix: DH-23028: Don't freeze protobuf message#8194

Merged
niloc132 merged 4 commits into
deephaven:mainfrom
niloc132:23028-frozen-message
Jul 6, 2026
Merged

fix: DH-23028: Don't freeze protobuf message#8194
niloc132 merged 4 commits into
deephaven:mainfrom
niloc132:23028-frozen-message

Conversation

@elijahpetty

@elijahpetty elijahpetty commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

The added test doesn't actually fail at this time, as the tests aren't run in "strict" mode, but the UI and doc tool are, which triggers the bug when a frozen object has new properties assigned to it.

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

No docs changes detected for 2dc2db8

mattrunyon
mattrunyon previously approved these changes Jul 2, 2026
@niloc132

niloc132 commented Jul 6, 2026

Copy link
Copy Markdown
Member

The test is passing when run properly, but it also is run as if it were a plain java test, so it passes and fails in the same build.

@niloc132 niloc132 enabled auto-merge (squash) July 6, 2026 18:27
@niloc132 niloc132 merged commit 4ee3164 into deephaven:main Jul 6, 2026
23 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants