ci: Fix docs nightlies potentially running some examples against latest#8195
Merged
mattrunyon merged 1 commit intoJul 7, 2026
Merged
Conversation
Contributor
No docs changes detected for 4a1c52d |
mattrunyon
added
NoDocumentationNeeded
NoReleaseNotesNeeded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically when the pyclient-version build step ran, it didn't pass the server tag, so it set it to latest and I think this could accidentally write a new image to
ghcr.io/deephaven/server:edgein the local Docker repo when the server ran. That server may have actually been latest tag and thus cause other snapshots to run against latest, not edge. The snapshot tool only pulls images once, so I think if it ran the non-pyclient tests after pyclient, it would be using the pyclient-server and could use the wrong image foredge.Remove the default so it will fail entirely on pyclient instead of pulling a default image. Also updates
IMAGEso the inheritedserverconfig doesn't write toghcr.io/deephaven/server:edgelocally after the build.