fix: DH-21438: fix performance regression caused by recent changes#310
Merged
kosak merged 1 commit intodeephaven:mainfrom Jan 21, 2026
Merged
fix: DH-21438: fix performance regression caused by recent changes#310kosak merged 1 commit intodeephaven:mainfrom
kosak merged 1 commit intodeephaven:mainfrom
Conversation
kosak
force-pushed
the
kosak_common-case
branch
from
c40ba82 to
ec26ba8
Compare
kosak
force-pushed
the
kosak_common-case
branch
from
ec26ba8 to
d7c12d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our benchmarks showed that #309 caused a 5-10% performance regression.
By inlining the character scans in a couple of places we are able to recapture that performance and even do a little better (on the order of 1-2%) than we were doing originally.