feat: DH-18349: Keep ui.tabs mounted when not active#1177
Merged
Conversation
|
ui docs preview (Available for 14 days) |
mattrunyon
force-pushed
the
mattrunyon_dh-18349
branch
from
714bcac to
5e2b434
Compare
|
ui docs preview (Available for 14 days) |
1 similar comment
|
ui docs preview (Available for 14 days) |
mattrunyon
added a commit
to deephaven/web-client-ui
that referenced
this pull request
May 6, 2025
…hey are not active (#2434) Part of DH-18349. Will need a small update in dh.ui to enable support there which is what the ticket wants. Does not change default behavior of `TabPanels`, just adds an extra param to keep static panels mounted (in React, but not actually mounted in the DOM). There are unit tests, but can also test with local plugins from this PR deephaven/deephaven-plugins#1177
mattrunyon
added a commit
to mattrunyon/web-client-ui
that referenced
this pull request
May 6, 2025
…hey are not active (deephaven#2434) Part of DH-18349. Will need a small update in dh.ui to enable support there which is what the ticket wants. Does not change default behavior of `TabPanels`, just adds an extra param to keep static panels mounted (in React, but not actually mounted in the DOM). There are unit tests, but can also test with local plugins from this PR deephaven/deephaven-plugins#1177
mattrunyon
requested review from
a team and
vbabich
and removed request for
a team
|
ui docs preview (Available for 14 days) |
vbabich
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with the snippet in DH-18349 and the following
If you run this on latest DH core, when you switch tabs you will see a loading spinner flicker and any client-side changes to the table will be lost (sort, filter, scroll, etc.)
With this change, you won't see the spinner flicker and the client state should be persisted. If you scroll/filter/sort any of the tables, then swap tabs and swap back, the table will be in the same state as when you left the tab.