Commit 2eefd4d
authored
DH-21980:
The MS Python extension can inject a command to activate venv whenever a
new terminal is opened. There is a race condition in that there is no
guarantee the command will run before other commands are started in the
terminal session. If a pip managed server is started before the command
is injected, the injection will kill the server. I have observed this
mostly in single folder workspaces.
Here's an example of the injected cmd killing the server:
<img width="1259" height="463" alt="image"
src="https://github.com/user-attachments/assets/4ffdd596-5866-4d04-82a8-4c048ef99d06"
/>
This fix simply hides the terminal so that the injection never happens
for pip managed servers.
## Testing
- Open a folder in VS Code and activate a Python venv
- Install deephaven-server pip package
- Start a managed server from VS Code extension
- It should start and stay connected
1 parent 7fad125 commit 2eefd4d
1 file changed
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
274 | 274 | | |
275 | 275 | | |
276 | 276 | | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
277 | 285 | | |
278 | 286 | | |
279 | 287 | | |
| |||
0 commit comments