test: DH-20440: Support for worker creation UI in e2e tests (#308)

DH-20440: Support for worker creation UI in e2e tests (aka. gplus
servers)

### Testing
Install dependencies 
`npm install`

Run tests against a gplus server (I've been using dev-gplus due to
current flakiness of qa gplus)
`npm run test:e2e -- --coreplus https://dev-gplus.int.illumon.com:8123/`

All tests should pass. There are occasions where there are flaky tests.
Usually trying again will succeed.

Author: bmingles

.gitignore

@@ -2,6 +2,7 @@ out
 dist
 node_modules
 /*.vsix
+.claude
 .vscode-test/
 .DS_Store
 e2e-testing/.resources

e2e-testing/src/specs/panels.spec.ts

@@ -3,6 +3,7 @@ import {
   connectToServer,
   executeCommandWithRetry,
   expectDeepEqualArray,
+  getIsCreateQueryIframeSupported,
   runDhFileCodeLens,
   setup,
   SIMPLE_TICKING3_PY,
@@ -49,9 +50,17 @@ const expectedTabs = {
 };
 
 describe('Panels Tests', () => {
-  before(async () => {
+  before(async function () {
+    const isCreateQueryIframeSupported = await getIsCreateQueryIframeSupported(
+      process.env.DH_SERVER_URL
+    );
+
+    if (isCreateQueryIframeSupported) {
+      this.timeout(120_000);
+    }
+
     await setup(SIMPLE_TICKING3_PY.path);
-    await connectToServer();
+    await connectToServer(isCreateQueryIframeSupported);
     await executeCommandWithRetry('View: Split Editor Down');
   });
 

e2e-testing/src/specs/statusBar.spec.ts

@@ -1,6 +1,7 @@
 import { InputBox } from 'vscode-extension-tester';
 import {
   getDhStatusBarItem,
+  getIsCreateQueryIframeSupported,
   getServerItems,
   getSidebarViewItem,
   setup,
@@ -18,8 +19,13 @@ import { VIEW_NAME } from '../util/constants';
 
 describe('Status Bar Tests', () => {
   let editorView: EditorViewExtended;
+  let isCreateQueryIframeSupported: boolean;
+
+  before(async function () {
+    isCreateQueryIframeSupported = await getIsCreateQueryIframeSupported(
+      process.env.DH_SERVER_URL
+    );
 
-  before(async () => {
     await setup(
       SIMPLE_TICKING_MD.path,
       SIMPLE_TICKING3_PY.path,
@@ -57,7 +63,10 @@ describe('Status Bar Tests', () => {
     }
   });
 
-  it('should connect to server on click', async () => {
+  it('should connect to server on click', async function () {
+    if (isCreateQueryIframeSupported) {
+      this.timeout(120_000);
+    }
     await editorView.openTextEditor(SIMPLE_TICKING3_PY.name);
 
     await step(1, 'Click Deephaven status bar item', async stepLabel => {
@@ -70,7 +79,7 @@ describe('Status Bar Tests', () => {
       const input = await InputBox.create();
       await input.selectQuickPick(0);
 
-      await waitForServerConnection();
+      await waitForServerConnection(isCreateQueryIframeSupported);
     });
 
     await step(3, 'Verify server node', async stepLabel => {

e2e-testing/src/util/testUtils.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import {
   ActivityBar,
   By,
@@ -45,9 +46,12 @@ export async function closeActivityBarView(name: string): Promise<void> {
  * this more flexible in the future. Also, there needs to be an active editor
  * for the command to work, so ensure a file is opened before calling this
  * function.
+ * @param isCreateQueryIframeSupported Whether the server requires the "Create
+ * Connection" webview form. Pass the result of `isCreateQueryIframeServer()`.
  */
-export async function connectToServer(): Promise<void> {
-  // eslint-disable-next-line no-console
+export async function connectToServer(
+  isCreateQueryIframeSupported = false
+): Promise<void> {
   console.log('Connecting to Deephaven server...');
 
   await executeCommandWithRetry('Deephaven: Select Connection');
@@ -58,7 +62,7 @@ export async function connectToServer(): Promise<void> {
   const input = await InputBox.create();
   await input.selectQuickPick(0);
 
-  await waitForServerConnection();
+  await waitForServerConnection(isCreateQueryIframeSupported);
 }
 
 /**
@@ -169,15 +173,13 @@ export async function executeWithRetry<T>(
       );
 
       if (!isRetryableError) {
-        // eslint-disable-next-line no-console
         console.error('Non-retryable error encountered:', error);
         throw error;
       }
 
       const hasRetryAttemptsRemaining = retryAttempt < maxRetries;
 
       if (!hasRetryAttemptsRemaining) {
-        // eslint-disable-next-line no-console
         console.error('Max retry attempts reached. Last error:', error);
         throw error;
       }
@@ -379,7 +381,6 @@ export async function openFileResources(
     return;
   }
 
-  // eslint-disable-next-line no-console
   console.log('Opening filePaths:', filePaths);
 
   // In CI environment, openResources doesn't work on Linux. Using the quick open
@@ -399,8 +400,10 @@ export async function openFileResources(
  * @param editor Editor to execute code lens in
  */
 export async function runDhFileCodeLens(editor: TextEditor): Promise<void> {
-  const runDhFileCodeLens = await getCodeLens(editor, 'Run Deephaven File');
-  await runDhFileCodeLens.click();
+  await executeWithRetry(async () => {
+    const runDhFileCodeLens = await getCodeLens(editor, 'Run Deephaven File');
+    await runDhFileCodeLens.click();
+  });
 }
 
 /**
@@ -422,7 +425,6 @@ export async function step<TResult>(
   fn: (stepLabel: string) => Promise<TResult>
 ): Promise<TResult> {
   const stepLabel = `Step ${n}: ${label}`;
-  // eslint-disable-next-line no-console
   console.log(stepLabel);
   return fn(stepLabel);
 }
@@ -485,7 +487,6 @@ export async function switchToFrame(
         throw err;
       }
 
-      // eslint-disable-next-line no-console
       console.log(`Retrying after '${errorType}' error`);
 
       // Try retrieving the iframe and switching again
@@ -497,21 +498,131 @@ export async function switchToFrame(
       try {
         await driver.switchTo().frame(iframe);
       } catch (err) {
-        // eslint-disable-next-line no-console
         console.log(`Failed to switch to frame: ${iframeOrIdentifier}`, err);
         throw err;
       }
     }
   }
 }
 
+/**
+ * Check if the given server URL requires the "Create Connection" webview form
+ * to create a worker. Mirrors the getDheFeatures() check in src/dh/dhe.ts using
+ * the same endpoint and response validation.
+ */
+export async function getIsCreateQueryIframeSupported(
+  serverUrl: string | undefined
+): Promise<boolean> {
+  if (serverUrl == null) {
+    return false;
+  }
+
+  try {
+    const res = await fetch(new URL('/iriside/features.json', serverUrl));
+    if (!res.ok || res.headers.get('content-type') !== 'application/json') {
+      console.log(
+        `[getIsCreateQueryIframe] Unsupported. Status: ${res.status}, Content-Type: ${res.headers.get('content-type')}`
+      );
+      return false;
+    }
+    const json = await res.json();
+    return json?.features?.createQueryIframe === true;
+  } catch (err) {
+    console.error(`[getIsCreateQueryIframe] Error at ${serverUrl}:`, err);
+    return false;
+  }
+}
+
+/**
+ * Fill in and submit the "Create Connection" webview form that appears for
+ * servers with the `createQueryIframe` feature. Sets Heap Size to 0.5 GB and
+ * Language to Python, then clicks Connect.
+ */
+async function handleCreateQueryForm(): Promise<void> {
+  const { driver } = VSBrowser.instance;
+
+  // The Create Connection panel is a VS Code WebviewView rendered as an iframe
+  // with src containing "purpose=webviewView".
+  // Navigate: outer sidebar iframe → #active-frame → #content-iframe.
+  await switchToFrame([
+    'iframe[src*="purpose=webviewView"]',
+    '#active-frame',
+    '#content-iframe',
+  ]);
+
+  console.log('[handleCreateQueryForm] Waiting for form to load...');
+  // Wait for the form to finish loading (blank panel / spinner may appear first)
+  const heapInput = await driver.wait<WebElement>(async () => {
+    const [el] = await driver.findElements(
+      By.css('.form-control.inputHeapSize')
+    );
+    return el;
+  });
+
+  console.log('[handleCreateQueryForm] Form loaded. Setting heap size...');
+  await heapInput.clear();
+  await heapInput.sendKeys('0.5');
+
+  const langSelect = await driver.findElement(
+    By.css('.custom-select.inputLanguage')
+  );
+  for (const option of await langSelect.findElements(By.css('option'))) {
+    if ((await option.getText()) === 'Python') {
+      await option.click();
+      break;
+    }
+  }
+
+  console.log('[handleCreateQueryForm] Language set. Clicking Connect...');
+  const connectBtn = await driver.findElement(
+    By.css('button[type="submit"].btn-primary')
+  );
+  await connectBtn.click();
+
+  console.log(
+    '[handleCreateQueryForm] Connect clicked. Waiting for panel to finish...'
+  );
+
+  console.log('[handleCreateQueryForm] Returning to default content.');
+  await driver.switchTo().defaultContent();
+
+  // Wait for the outer sidebar iframe to become hidden. VS Code keeps the iframe
+  // in the DOM when a WebviewView panel closes but hides it via CSS — so check
+  // isDisplayed() rather than DOM presence. The panel hides once the worker is
+  // fully created, which is the tightest signal before the notification fires.
+  console.log('[handleCreateQueryForm] Waiting for panel to close...');
+  try {
+    await driver.wait(async () => {
+      const [frame] = await driver.findElements(
+        By.css('iframe[src*="purpose=webviewView"]')
+      );
+
+      try {
+        return !(await frame.isDisplayed());
+      } catch {
+        return true; // stale
+      }
+    });
+  } catch (err) {
+    throw new Error(
+      `[handleCreateQueryForm] TIMEOUT waiting for panel to close: ${err}`
+    );
+  }
+
+  console.log('[handleCreateQueryForm] Panel closed.');
+}
+
 /**
  * Wait for Deephaven server connection to complete, handling username/password
  * input if prompted. Also handles authentication method selection if the server
  * supports both SAML and Basic authentication. Closes the "Created Deephaven
  * session" notification when connection is established.
+ * @param isCreateQueryIframeSupported Whether the server requires the "Create
+ * Connection" webview form
  */
-export async function waitForServerConnection(): Promise<void> {
+export async function waitForServerConnection(
+  isCreateQueryIframeSupported: boolean
+): Promise<void> {
   let firstInputBox: InputBox | null = null;
   try {
     firstInputBox = await InputBox.create();
@@ -561,6 +672,11 @@ export async function waitForServerConnection(): Promise<void> {
     await passwordInputBox.confirm();
   }
 
+  // Handle "Create Connection" form for servers with the createQueryIframe feature
+  if (isCreateQueryIframeSupported) {
+    await handleCreateQueryForm();
+  }
+
   // Wait for connection to be active
   const notification = await VSBrowser.instance.driver.wait<Notification>(
     getServerConnectedNotification

scripts/e2e.sh

@@ -82,6 +82,8 @@ else
     node scripts/generate-test-settings.mjs --coreplus "${SERVER_URL}"
 fi
 
+export DH_SERVER_URL="${SERVER_URL}"
+
 # Run e2e tests
 echo "Running E2E tests..."
 node e2e-testing/out/runner.mjs --setup