chore: update plotly version to 3.0.0#2455
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Plotly.js library and its TypeScript definitions to version 3.0.0 as part of dependency maintenance.
- Updated Plotly.js dependency in packages/chart/package.json
- Updated @types/plotly.js dependency in package.json
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/chart/package.json | Upgraded Plotly.js version from 2.29.1 to 3.0.0 |
| package.json | Upgraded @types/plotly.js version from 2.33.0 to 3.0.0 |
Comments suppressed due to low confidence (2)
packages/chart/package.json:43
- Ensure that any breaking changes introduced in Plotly.js 3.0.0 are addressed in the application logic, especially if there are direct usages of Plotly APIs.
"plotly.js": "^3.0.0",
package.json:96
- Verify that the updated type definitions for Plotly.js align with your current TypeScript codebase and update any type-related code if necessary.
"@types/plotly.js": "^3.0.0",
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2455 +/- ##
========================================
Coverage 44.62% 44.62%
========================================
Files 759 759
Lines 42550 42550
Branches 10693 10887 +194
========================================
Hits 18989 18989
+ Misses 23550 23505 -45
- Partials 11 56 +45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Will merge after deephaven/deephaven-plugins#1179 |
|
@mofojed I think we need to merge this one first, unless I am misunderstanding some failures in the e2e tests for deephaven/deephaven-plugins#1179 There are failures that indicate the types in inherited methods don't match, which makes sense as the versions are different. |
|
@jnumainville I'm a moron, had a brainfart. Yes this needs to merge first. |
Update as requested in deephaven/deephaven-plugins#1179