Skip to content

chore: update plotly version to 3.0.0#2455

Merged
mofojed merged 9 commits into
deephaven:mainfrom
jnumainville:update_plotly
Jul 14, 2025
Merged

chore: update plotly version to 3.0.0#2455
mofojed merged 9 commits into
deephaven:mainfrom
jnumainville:update_plotly

Conversation

@jnumainville

Copy link
Copy Markdown
Contributor

Update as requested in deephaven/deephaven-plugins#1179

@jnumainville jnumainville requested a review from Copilot May 29, 2025 15:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Plotly.js library and its TypeScript definitions to version 3.0.0 as part of dependency maintenance.

  • Updated Plotly.js dependency in packages/chart/package.json
  • Updated @types/plotly.js dependency in package.json

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/chart/package.json Upgraded Plotly.js version from 2.29.1 to 3.0.0
package.json Upgraded @types/plotly.js version from 2.33.0 to 3.0.0
Comments suppressed due to low confidence (2)

packages/chart/package.json:43

  • Ensure that any breaking changes introduced in Plotly.js 3.0.0 are addressed in the application logic, especially if there are direct usages of Plotly APIs.
"plotly.js": "^3.0.0",

package.json:96

  • Verify that the updated type definitions for Plotly.js align with your current TypeScript codebase and update any type-related code if necessary.
"@types/plotly.js": "^3.0.0",

@codecov

codecov Bot commented May 29, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 44.62%. Comparing base (411f648) to head (674de89).

Files with missing lines Patch % Lines
packages/chart/src/MockChartModel.ts 0.00% 3 Missing ⚠️
packages/chart/src/FigureChartModel.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2455    +/-   ##
========================================
  Coverage   44.62%   44.62%            
========================================
  Files         759      759            
  Lines       42550    42550            
  Branches    10693    10887   +194     
========================================
  Hits        18989    18989            
+ Misses      23550    23505    -45     
- Partials       11       56    +45     
Flag Coverage Δ
unit 44.62% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread packages/chart/src/MockChartModel.ts Outdated
@jnumainville jnumainville marked this pull request as ready for review July 14, 2025 16:37
@jnumainville jnumainville requested a review from mofojed July 14, 2025 16:37
@mofojed

mofojed commented Jul 14, 2025

Copy link
Copy Markdown
Member

Will merge after deephaven/deephaven-plugins#1179

@jnumainville

Copy link
Copy Markdown
Contributor Author

@mofojed I think we need to merge this one first, unless I am misunderstanding some failures in the e2e tests for deephaven/deephaven-plugins#1179
See this run:
https://github.com/deephaven/deephaven-plugins/actions/runs/16271166961/job/45938901389?pr=1179

There are failures that indicate the types in inherited methods don't match, which makes sense as the versions are different.

@mofojed

mofojed commented Jul 14, 2025

Copy link
Copy Markdown
Member

@jnumainville I'm a moron, had a brainfart. Yes this needs to merge first.

@mofojed mofojed merged commit 7785090 into deephaven:main Jul 14, 2025
11 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants