cockpit: Fix CVE-2026-4631#3
Merged
Merged
Conversation
CVE-2026-4631: Cockpit's remote login feature passes user-supplied hostnames and usernames from the web interface to the SSH client without validation or sanitization. An attacker with network access to the Cockpit web service can craft a single HTTP request to the login endpoint that injects malicious SSH options or shell commands, achieving code execution on the Cockpit host without valid credentials. This patch adds `--` to SSH command invocations to ensure hostnames are interpreted correctly and cannot be treated as command-line options. Upstream: cockpit-project/cockpit@9d06956
|
TAG Bot TAG: 328-1deepin2 |
Contributor
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/integrate |
|
AutoIntegrationPr Bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Update
Description
Cockpit's remote login feature passes user-supplied hostnames and usernames
from the web interface to the SSH client without validation or sanitization.
An attacker with network access to the Cockpit web service can craft a single
HTTP request to the login endpoint that injects malicious SSH options or shell
commands, achieving code execution on the Cockpit host without valid credentials.
Changes
--to SSH command invocations insrc/cockpit/beiboot.py--to SSH command invocations insrc/ws/cockpitauth.cUpstream
cockpit-project/cockpit@9d06956
Testing