[linux-6.6.y] ALSA: hda: Add support of Zhaoxin SB HDAC

[leoliu-oc]

zhaoxin inclusion
category: feature

---

Add some special initialization for Zhaoxin SB HDAC.

Summary by Sourcery

New Features:

• Treat Zhaoxin SB HDAC controllers as VIA-compatible for position fix selection and non-snoop mode handling.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Extends the existing VIA-specific handling in the HDA Intel driver to also apply to Zhaoxin southbridge HD audio controllers by reusing the same position-fix logic and snoop behavior checks.

File-Level Changes

Change	Details	Files
Apply existing VIA-specific position-fix handling to Zhaoxin HDA controllers.	Update the condition in check_position_fix() to treat AZX_DRIVER_ZHAOXIN the same as AZX_DRIVER_VIA for selecting POS_FIX_VIACOMBO. Ensure debug logging still clearly indicates the use of the VIACOMBO position fix when Zhaoxin hardware is detected.	sound/pci/hda/hda_intel.c
Apply VIA-style snoop-availability handling to Zhaoxin HDA controllers.	Extend azx_check_snoop_available() to check for AZX_DRIVER_ZHAOXIN alongside AZX_DRIVER_VIA when deciding to force non-snoop mode if the snoop type is none. Preserve existing behavior for other controller types while broadening support to Zhaoxin hardware.	sound/pci/hda/hda_intel.c

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

Hi @leoliu-oc. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sourcery-ai]

Hey - I've left some high level feedback:

• Now that Zhaoxin is treated equivalently to VIA in multiple places, consider introducing a small helper (e.g., is_via_like_controller(chip)) to avoid repeating the composite driver_type checks and make future updates less error-prone.
• The debug message "Using VIACOMBO position fix" may be confusing when the driver type is ZHAOXIN; consider updating the string to reflect both VIA and Zhaoxin or using a more generic description.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Now that Zhaoxin is treated equivalently to VIA in multiple places, consider introducing a small helper (e.g., `is_via_like_controller(chip)`) to avoid repeating the composite `driver_type` checks and make future updates less error-prone.
- The debug message `"Using VIACOMBO position fix"` may be confusing when the driver type is ZHAOXIN; consider updating the string to reflect both VIA and Zhaoxin or using a more generic description.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Copilot]

Pull request overview

Adds Zhaoxin SB HDAC support to the Intel HDA driver by handling AZX_DRIVER_ZHAOXIN controllers alongside VIA controllers in two driver-type checks (position-fix selection and snoop availability).

Changes:

• Use VIACOMBO position fix for AZX_DRIVER_ZHAOXIN in check_position_fix().
• Force non-snoop mode for AZX_DRIVER_ZHAOXIN in azx_check_snoop_available() when BIOS configures it.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: opsiff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• deepin/OWNERS [opsiff]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment